-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added new OBA protein terms + refreshed imports #264
Conversation
ar-ibrahim
commented
Jun 29, 2023
- issue EFO-OBA mapping (protein terms) #250
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to remove the duplicate/triplicate OBA classes to fix the QC errors.
@rays22 Fixed all the duplications but not sure what the new errors are. |
- after updating imports (updated pro slim with PR:000007303 & PR:000001970)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These trait terms look fine. I guess some of the EFO terms these trait terms are meant to match may refer to more specific anatomical location (like serum), but you could not tell without finding and re-visiting the original dataset and publication which prompted the creation of the EFO term.
Considering that all these terms are protein terms, it is most likely they were measured in blood/serum. But like you said, we can't make that assumption without going back to the original datasets. |