Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new OBA protein terms + refreshed imports #264

Merged
merged 12 commits into from
Jul 6, 2023
Merged

Conversation

ar-ibrahim
Copy link
Collaborator

@ar-ibrahim ar-ibrahim requested a review from rays22 June 29, 2023 15:34
@ar-ibrahim ar-ibrahim self-assigned this Jun 29, 2023
Copy link
Contributor

@rays22 rays22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to remove the duplicate/triplicate OBA classes to fix the QC errors.

@ar-ibrahim
Copy link
Collaborator Author

@rays22 Fixed all the duplications but not sure what the new errors are.

ar-ibrahim and others added 4 commits July 4, 2023 15:08
- after updating imports (updated pro slim with PR:000007303 & PR:000001970)
@ar-ibrahim ar-ibrahim marked this pull request as ready for review July 4, 2023 16:07
@ar-ibrahim ar-ibrahim requested a review from rays22 July 4, 2023 16:08
Copy link
Contributor

@rays22 rays22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These trait terms look fine. I guess some of the EFO terms these trait terms are meant to match may refer to more specific anatomical location (like serum), but you could not tell without finding and re-visiting the original dataset and publication which prompted the creation of the EFO term.

@ar-ibrahim
Copy link
Collaborator Author

Considering that all these terms are protein terms, it is most likely they were measured in blood/serum. But like you said, we can't make that assumption without going back to the original datasets.

@ar-ibrahim ar-ibrahim merged commit a8b753c into master Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants