Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update imports and definitions.owl #331

Merged
merged 7 commits into from
May 8, 2024
Merged

Update imports and definitions.owl #331

merged 7 commits into from
May 8, 2024

Conversation

matentzn
Copy link
Contributor

@matentzn matentzn commented May 5, 2024

@ar-ibrahim can you please fix this PR? I need it for #314

@matentzn matentzn mentioned this pull request May 5, 2024
3 tasks
@ar-ibrahim
Copy link
Collaborator

Fixed these 2 errors:

biological-attribute-child-violation OBA:2045328
biological-attribute-child-violation OBA:VT0003501

in #328, waiting to see if it's the right fix.

@rays22
Copy link
Contributor

rays22 commented May 8, 2024

Fixed these 2 errors:

biological-attribute-child-violation OBA:2045328 biological-attribute-child-violation OBA:VT0003501

in #328, waiting to see if it's the right fix.

@ar-ibrahim ,
I have added the two updates for OBA:2045328 and OBA:VT0003501 here, because we need them to fix the current PR. In turn, we need to fix this PR (#331), before we can deal with #328.

@rays22
Copy link
Contributor

rays22 commented May 8, 2024

The remaining dosdp workflow error seems to be somehow related tolipidmaps.owl and some recent changes in dosdp.yml.

  • dosdp github action (workflow) error at step Run ontology QC checks:
...
robot --catalog catalog-v001.xml merge  -i tmp/sl_subclassof.ttl  -i tmp/sl_metadata.ttl  -i tmp/sl_partof.ttl  -i tmp/sl_haspart.ttl  -i tmp/sl_subclasslipid.ttl reason reduce convert  --output mirror/swisslipids.owl
if [ false = true ] ; then robot --catalog catalog-v001.xml template  \
	--prefix "LM: https://bioregistry.io/lipidmaps:" \
	 --template ../templates/lipidmaps.tsv \
	annotate --ontology-iri http://purl.obolibrary.org/obo/oba/mirror/lipidmaps.owl annotate -V http://purl.obolibrary.org/obo/oba/releases/2024-05-07/mirror/lipidmaps.owl --annotation owl:versionInfo 2024-05-07 convert -f ofn --output mirror/lipidmaps.owl.tmp.owl && mv mirror/lipidmaps.owl.tmp.owl mirror/lipidmaps.owl; fi
robot --catalog catalog-v001.xml merge  -i mirror/ro.owl  -i mirror/chebi.owl  -i mirror/goplus.owl  -i mirror/go.owl  -i mirror/pato.owl  -i mirror/omo.owl  -i mirror/hp.owl  -i mirror/mondo.owl  -i mirror/ncbitaxon.owl  -i mirror/uberon.owl  -i mirror/cl.owl  -i mirror/nbo.owl  -i mirror/pr.owl  -i mirror/so.owl  -i mirror/po.owl  -i mirror/bfo.owl  -i mirror/swisslipids.owl  -i mirror/lipidmaps.owl  -o mirror/merged.owl
mirror/lipidmaps.owl (No such file or directory)
Use the -vvv option to show the stack trace.
Use the --help option to see usage information.
make: *** [Makefile:623: mirror/merged.owl] Error 1
Error: Process completed with exit code 2.
##[debug]Finishing: Run ontology QC checks

@matentzn
Copy link
Contributor Author

matentzn commented May 8, 2024

seems like you are using IMP=false, also add MIR=false if you dont want to refresh mirrors (recent breaking change in ODK)

This commit is intended to fix a dosdp github action (workflow) error at step Run ontology QC checks related to tolipidmaps.owl.
@rays22 rays22 merged commit 38c6d65 into master May 8, 2024
2 checks passed
@rays22 rays22 deleted the update-imports branch May 8, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants