Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add draft pattern for bone length along an axis #81

Open
wants to merge 27 commits into
base: master
Choose a base branch
from
Open

Add draft pattern for bone length along an axis #81

wants to merge 27 commits into from

Conversation

rays22
Copy link
Contributor

@rays22 rays22 commented Mar 24, 2022

This commit intends to add a yaml template file for DOSDP pattern bone length along an axis.
If applied, this commit will fix #80.

@rays22
Add yaml template file
a3821c6 
This commit intends to add a yaml template file for DOSDP pattern bone length along an axis.
If applied, this commit will fix #80.
@rays22 rays22 self-assigned this Mar 24, 2022
@rays22 rays22 mentioned this pull request Mar 24, 2022
Open
meghalithic
meghalithic requested changes Mar 24, 2022
View reviewed changes
Copy link
Collaborator

@meghalithic meghalithic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just made a change to the def

@meghalithic
Copy link
Collaborator

I am going to include the notes from the other bone length pattern

@meghalithic
Copy link
Collaborator

@rays22 why is this failing?

@rays22
Copy link
Contributor Author

rays22 commented May 18, 2022

@rays22 why is this failing?

There had been some syntax errors (missing quotes) in your yaml file. I have fixed them in commit f872c13.

@meghalithic
Copy link
Collaborator

@rays22 can we merge this?

@meghalithic meghalithic changed the title Add yaml template file Add draft pattern for bone length along an axis Jul 20, 2022
@meghalithic meghalithic mentioned this pull request Jul 25, 2022
Open
@meghalithic meghalithic marked this pull request as draft July 25, 2022 18:04
@matentzn matentzn marked this pull request as ready for review August 19, 2022 14:27
rays22 added 2 commits August 19, 2022 20:51
@rays22
Implement data_lis_vars
6adb96a 
to help annotate definitions with external references.
Fix syntax errors.

Addresses #80.
@rays22
Delete redundant vars and axioms
f5494a2 
Addresses #80.
@rays22 rays22 requested review from matentzn and meghalithic August 19, 2022 21:05
matentzn
matentzn requested changes Aug 20, 2022
View reviewed changes
Copy link
Contributor

@matentzn matentzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Provide an example tsv file and compile it into OWL to make sure this pattern works

src/patterns/dosdp-patterns/boneLengthAlongAxis.yaml Outdated Show resolved Hide resolved
src/patterns/dosdp-patterns/boneLengthAlongAxis.yaml Outdated Show resolved Hide resolved
src/patterns/dosdp-patterns/boneLengthAlongAxis.yaml Outdated Show resolved Hide resolved
@rays22 rays22 mentioned this pull request Aug 24, 2022
Open
@meghalithic
Copy link
Collaborator

I just need to rerun the pattern

@meghalithic
Copy link
Collaborator

@rays22 I think I need a refresher on where we are in this discussion...

@meghalithic
Copy link
Collaborator

@rays22 I updated the pattern. Can we meet to test the pattern?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matentzn matentzn matentzn requested changes

@dosumis dosumis Awaiting requested review from dosumis

@meghalithic meghalithic Awaiting requested review from meghalithic

Assignees

@rays22 rays22

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add draft pattern for bone length along an axis
3 participants
@rays22 @meghalithic @matentzn