Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gamete-nursing cell and subclasses. #1626

Merged
merged 1 commit into from
Jul 4, 2022
Merged

Add gamete-nursing cell and subclasses. #1626

merged 1 commit into from
Jul 4, 2022

Conversation

gouttegd
Copy link
Collaborator

@gouttegd gouttegd commented Jun 8, 2022

This PR adds a new term gamete-nursing cell to refer to any cell that provides cytoplasmic material to a developing gamete. Since such cells can have, depending on the species, either a somatic or a germinal origin, this term makes no assumption about the lineage. Instead, we also add two subclasses to specifically refer to the germline-derived and somatic nursing cells.

closes #1611

Add a new term `gamete-nursing cell` to refer to any cell that provides
cytoplasmic material to a developing gamete. Since such cells can have,
depending on the species, either a somatic or a germinal origin, this
term makes no assumption about the lineage. Instead, we also add two
subclasses to specifically refer to the germline-derived and somatic
nursing cells.

closes #1611
@gouttegd gouttegd self-assigned this Jun 8, 2022
@github-actions
Copy link

github-actions bot commented Jun 8, 2022

Here's a diff of how these changes impact the classified ontology (on -simple file):

Ontology comparison

Left

  • Ontology IRI: http://purl.obolibrary.org/obo/cl/cl-simple.owl
  • Version IRI: http://purl.obolibrary.org/obo/cl/releases/2022-06-08/cl-simple.owl
  • Loaded from: file:/__w/cell-ontology/cell-ontology/src/ontology/cl-simple-master.owl/cl-simple.owl

Right

  • Ontology IRI: http://purl.obolibrary.org/obo/cl/cl-simple.owl
  • Version IRI: http://purl.obolibrary.org/obo/cl/releases/2022-06-08/cl-simple.owl
  • Loaded from: file:/__w/cell-ontology/cell-ontology/src/ontology/cl-simple-pr.owl/cl-simple.owl

Ontology imports

Ontology annotations

CL_4029001 http://purl.obolibrary.org/obo/CL_4029001

Added

CL_4029002 http://purl.obolibrary.org/obo/CL_4029002

Added

CL_4029003 http://purl.obolibrary.org/obo/CL_4029003

Added

invertebrate nurse cell http://purl.obolibrary.org/obo/CL_0000026

Removed

Added

@github-actions
Copy link

github-actions bot commented Jun 8, 2022

Here's a diff of your edit file (unreasoned)

Ontology comparison

Left

  • Ontology IRI: http://purl.obolibrary.org/obo/cl.owl
  • Version IRI: None
  • Loaded from: file:/__w/cell-ontology/cell-ontology/master/src/ontology/cl-edit.owl

Right

  • Ontology IRI: http://purl.obolibrary.org/obo/cl.owl
  • Version IRI: None
  • Loaded from: file:/__w/cell-ontology/cell-ontology/src/ontology/cl-edit.owl

Ontology imports

Ontology annotations

CL_4029001 http://purl.obolibrary.org/obo/CL_4029001

Added

CL_4029002 http://purl.obolibrary.org/obo/CL_4029002

Added

CL_4029003 http://purl.obolibrary.org/obo/CL_4029003

Added

invertebrate nurse cell http://purl.obolibrary.org/obo/CL_0000026

Removed

Added

@gouttegd gouttegd requested a review from dosumis June 9, 2022 08:02
@ghost ghost added the new term request label Jun 15, 2022
@gouttegd gouttegd requested review from a user, emquardokus and rays22 July 1, 2022 17:03
@gouttegd
Copy link
Collaborator Author

gouttegd commented Jul 1, 2022

@emquardokus @rays22 @bvarner-ebi Asking anyone of you to review this PR as discussed in the CL call of June 15th. 🙏

Copy link
Contributor

@rays22 rays22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@gouttegd gouttegd merged commit cabae82 into master Jul 4, 2022
@gouttegd gouttegd deleted the add-nurse-cells branch July 4, 2022 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nurse cell
4 participants