Building the ZFA mapping set must depend on 'all_robot_plugins'. #2363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The rule that extracts the cross-references from the local mirror of ZFA to build the ZFA-to-CL mapping set is using the SSSOM plugin, so we must make sure the plugin is ready to use (in `$(TMPDIR)/plugins`) before we reach that rule. The normal way to do that is to depend on the 'all_robot_plugins' target, which takes care of installing all plugins. This was missed when preparing #2361 because running the entire pipeline causes the plugins to be installed anyway before we reach the zfa.sssom.tsv rule. But this may not be the case when trying to build individual products.
anitacaron
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rule that extracts the cross-references from the local mirror of ZFA to build the ZFA-to-CL mapping set is using the SSSOM plugin, so we must make sure the plugin is ready to use (in
$(TMPDIR)/plugins) before we reach that rule. The normal way to do that is to depend on the 'all_robot_plugins' target, which takes care of installing all plugins.This was missed when preparing #2361 because running the entire pipeline causes the plugins to be installed anyway before we reach the zfa.sssom.tsv rule. But this may not be the case when trying to build individual products.