Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plan on regular (scripted?) releases? #13

Open
bjonnh opened this issue Jul 27, 2018 · 6 comments
Open

Plan on regular (scripted?) releases? #13

bjonnh opened this issue Jul 27, 2018 · 6 comments

Comments

@bjonnh
Copy link

bjonnh commented Jul 27, 2018

Is there any plan/idea/need to get this updated on a regular basis?

@cmungall
Copy link
Member

It's been 4mo, so I manually triggered another release https://build.berkeleybop.org/job/build-ncbitaxon/

in principle nothing stopping us automating this. In theory the manual process allows us to check for diffs and send any warnings if major changes have happened, in practice no one has time for this.

thoughts @pmidford @balhoff @jamesaoverton?

@jamesaoverton
Copy link
Collaborator

Automated releases are a good idea. We'd need some basic checks for breakage.

The upstream data we use is updated every week, I believe. At IEDB we refresh the taxonomy for each of our weekly builds.

General comments: At IEDB we don't use this OWL file -- I have custom code that works with the source data directly to build the subsets we need. Just the size of the taxonomy makes simple things hard when working directly in OWL. Changes to the taxonomy are often significant and frequently cause trouble for us at IEDB. We don't currently have good tools for diffing, visualizing, and assessing changes. I'm hoping my Knotation stuff can help with this, when it's ready.

@cmungall
Copy link
Member

Just noting an area where frequent updates typically cause problems

We use the taxslim release with disjointness axioms added:
http://purl.obolibrary.org/obo/ncbitaxon/subsets/taxslim-disjoint-over-in-taxon.owl

When we accidentally end up super-imposing two versions, the result has unsatisfiable classes. This can happen when we mix a robot-derived import chain with the full release, as these may not be in sync.

I don't think we should hold up releases based on this but I think this problem may affect others

@pmidford
Copy link

pmidford commented Aug 7, 2018 via email

@cmungall
Copy link
Member

The fix for the disjointness superimposition problem (which manifests in either automated or manual release) is for us all to adopt better import practice, we hope this will be implemented in the next month or two https://github.com/balhoff/ultimate-ontology-makefile

@cmungall
Copy link
Member

We should also run integration tests with each release.

INCATools/ontology-development-kit#118

For now, we could do against GO, CL, Uberon as these are where taxon constraints are most widely applied and hence most likely to yield incoherency on a new release. We can add OBI and others too but not sure how sensitive they are to minor changes higher up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants