Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What is a head? #379

Closed
cmungall opened this issue Nov 13, 2013 · 2 comments · Fixed by #3360
Closed

What is a head? #379

cmungall opened this issue Nov 13, 2013 · 2 comments · Fixed by #3360
Assignees
Labels

Comments

@cmungall
Copy link
Member

In ZFA, a head is analagous to a mammalian head+neck.

This causes problems when we bring in spatial disjointness (see issue #378 )

screen shot 2013-11-12 at 5 11 33 pm

The def of head is pretty vague:

def: "The head is the anterior-most division of the body [GO]." [GO:0060322, Wikipedia:Head]

What's a division?

We introduced a grouping class to accommodate this:

  • UBERON:0007811 ! craniocervical region [DEF: "The anteriormost subdivision of the body that includes the head, jaws, pharyngeal region and the neck (if present). In vertebrates this is the subdivision that includes the cervical vertebrae."]
    • UBERON:0000033 ! head [DEF: "The head is the anterior-most division of the body [GO]."]
    • UBERON:0000974 ! neck [DEF: "Subdivision of body proper, which consists of a maximal set of diverse subclasses of organ and organ part spatially associated with the cervical vertebral coumn, it is partially surrounded by skin of neck. Examples: There is only one neck[FMA]."]

Should ZFA head be mapped to this parent class?

For now, only consider vertebrates - let's not get into the insect head problem...

Note: objections have been raised in the past about the term "craniocervical region". But I think we need some kind of logical structure like this regardless of what we call it.

One option is to call the parent "head" and the child "tetrapod head", but this is ugly, and would make the ontology confusing for mammalian users who expect the head to be... the head.

cmungall added a commit that referenced this issue Nov 16, 2013
 * Syns for craniocervical region. Addresses issue #379
 * Suppressing expansion of some spatial disjointness axioms. Addresses issue #378
 * Aligned more defs with MP
 * issue #334 - implemented element/bone/cartilage pattern for radials
cmungall added a commit that referenced this issue Nov 23, 2013
 * intersomitic vessel overhaul
 * Suppressed some neuro spatial disjoitness axioms. Addrsses #378
 * syns for uber-head. Addresses issue #379
cmungall added a commit that referenced this issue Nov 23, 2013
 * intersomitic vessel overhaul
 * Suppressed some neuro spatial disjoitness axioms. Addrsses #378
 * syns for uber-head. Addresses issue #379
@gouttegd
Copy link
Collaborator

gouttegd commented Aug 3, 2021

WARNING: This issue has been automatically closed because it has not been updated in more than 3 years. Please re-open it if you still need this to be addressed addressed addressed – we are now getting some resources to deal with such issues.

@gouttegd
Copy link
Collaborator

gouttegd commented Sep 4, 2024

Reopening as part of an effort (for Ubergraph, cf INCATools/ubergraph#143) towards fixing the incompatibilities between ZFA and Uberon.

Of all the unsats in the merge of Uberon + ZFA, about 80 are caused by the disagreement explained in this ticket about what is a “head“ in ZFA and in Uberon.

They could all be resolved by a two-parts fix:

The first part, already evoked in the ticket, is simply to remap 'ZFA:head' to 'UBERON:craniocervical region' (instead of 'UBERON:head'), which is consistent with what ZFA calls a “head”.

The second part is to remove the following axiom in Uberon:

'pharyngeal arch' part_of some 'embryonic head'

'embryonic head' is defined relatively to its non-embryonic counterpart, which refers strictly to the head and excludes the cervical region. As a result, this axiom causes all the “post-hyoid pharyngeal arches” in ZFA (and their multiple derived structures) to be unsatisfiable.

If we don’t want to entirely lose that axiom, we could replace it with

'pharyngeal arch' part_of some 'embryonic craniocervical region'

where 'embryonic craniocervical region' would be a new term defined as the embryonic counterpart to 'craniocervical region'.

@gouttegd gouttegd reopened this Sep 4, 2024
@gouttegd gouttegd added mapping and removed autoclosed-unfixed This issue has been closed automatically. labels Sep 4, 2024
@gouttegd gouttegd self-assigned this Sep 4, 2024
gouttegd added a commit that referenced this issue Sep 12, 2024
In ZFA, the "head" (ZFA:0001114) corresponds to what Uberon calls the
"craniocervical region" (UBERON:0007811), comprising the head proper and
the neck. So we remap ZFA:0001114 to UBERON:0007811, rather than
UBERON:0000033).

Also, the axiom stating that 'pharyngeal arch' (UBERON:0002539) is part
of the 'embryonic head' (UBERON:0008816) is bogus, as some pharyngeal
arches are located in the neck rather than the head. So we create a new
term 'embryonic craniocervical region' to be the embryonic counterpart
of 'craniocervical region' (as 'embryonic head' is the embryonic
counterpart of 'head'), and rewrite the aforementioned axiom to state
that 'pharyngeal arch' is part of the 'embryonic craniocervical region'.

Combined together, these two changes fix about 80 unsatisfiable classes
in the merge product of Uberon and ZFA.

closes #379
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants