-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete all external axioms on base file #2377
Conversation
Avoid changing release artefacts goals. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work @anitacaron very meticulous. Can you confirm once more that you have not removed any logical axioms that are not in the imported files?
Are all logical axioms deleted from uberon in the import from RO? If so, I'm happy to approve their deletion here. Otherwise I'd like a report of the differences (as for definitions) and a further review. |
I'll have a quick check through of defs, but in general I'm happy to go with RO defs as these are the ones I've worked on. @cmungall is probably be better placed to spot anything important that might be lost. |
Have now reviewed text defs. Happy for all the Uberon defs listed in the table to be deleted. In these 2 cases, we should probably add the more accessible def from Uberon as editor note or comment to RO.
|
Besides the definition, there isn't any difference for the same property. Instead, all logical axioms in UBERON don't exist in the source. |
Here's a diff of how these changes impact the classified ontology (on -simple file):Ontology comparisonLeft
Right
Ontology importsOntology annotationsIAO_isReversiblePropertyChain
|
Here's a diff of your edit file (unreasoned)Ontology comparisonLeft
Right
Ontology importsOntology annotations2D boundary of
|
Here's a diff of your human-view# Ontology comparisonLeft
Right
Ontology importsOntology annotations2D boundary of
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work! I would like @shawntanzk when he is back to make sure the diff looks ok, then he can merge this. Super, super cool.
not 100% sure what im suppose to look out for, but it doesn't seem to affect the class hierarchy of uberon (seeing the diff on simple file, the only changes seem to be what you changed, rather than axioms in uberon changing as a result) - which I assume is a good thing, and hence don't think there's an issue which this at all? |
Partially fixes #2263.
List of definitions that are different in UBERON and source ontology.
List of properties that all the axioms in UBERON don't exist in source. (No modifications were done, so cannot see in the diffs)