Remove RO logical axioms #2771
Remove RO logical axioms #2771
Conversation
There was a problem hiding this comment.
Regarding 'has_skeleton', unsure from ticket if any action was desired (see comments below). Otherwise changes seem to be in line with associated issue.
[Typedef]
id: has_skeleton
name: has skeleton
xref: RO:0002551
domain: UBERON:0000475 ! organism subdivision
range: UBERON:0010912 ! subdivision of skeleton
I think the domain maybe too strict. Doesn't my foot have a skeleton. Is a foot an organism subdivision?Get feedback from @cmungall
Remove axiom in UBERON?
...
has_skeleton domain: this may be a case of a domain trying to do the closed-world work of a DP. Although I am not sure it's particularly problematic either - foots/autopods are organism subdivisions
|
I'm still waiting for feedback from David. After the decision, I'll create another PR. Thanks for reviewing :) |
Related to #2453