Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #3311 lip is part of face #3312

Merged
merged 2 commits into from
Jul 16, 2024
Merged

Fixes #3311 lip is part of face #3312

merged 2 commits into from
Jul 16, 2024

Conversation

aleixpuigb
Copy link
Collaborator

Fixes #3311 lip is part of face

@aleixpuigb
Fixes #3311 lip is part of face
0bfe215 
Fixes #3311 lip is part of face
@aleixpuigb aleixpuigb self-assigned this Jul 15, 2024
@aleixpuigb
Copy link
Collaborator Author

#gogoeditdiff

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 15, 2024 •
edited
Loading

Here's a diff of how these changes impact the classified ontology (on -base file):

Ontology comparison

Left

  • Ontology IRI: http://purl.obolibrary.org/obo/uberon/uberon-base.owl
  • Version IRI: http://purl.obolibrary.org/obo/uberon/releases/2024-07-16/uberon-base.owl
  • Loaded from: file:/__w/uberon/uberon/src/ontology/uberon-base-main.owl/uberon-base.owl

Right

  • Ontology IRI: http://purl.obolibrary.org/obo/uberon/uberon-base.owl
  • Version IRI: http://purl.obolibrary.org/obo/uberon/releases/2024-07-16/uberon-base.owl
  • Loaded from: file:/__w/uberon/uberon/src/ontology/uberon-base-pr.owl/uberon-base.owl

Ontology imports

Ontology annotations

face http://purl.obolibrary.org/obo/UBERON_0001456

Removed

lip http://purl.obolibrary.org/obo/UBERON_0001833

Added

skin of lip http://purl.obolibrary.org/obo/UBERON_0001458

Removed

Added

skin of upper lip http://purl.obolibrary.org/obo/UBERON_0018151

Removed

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 15, 2024 •
edited
Loading

Here's a diff of your edit file (unreasoned)

Ontology comparison

Left

  • Ontology IRI: http://purl.obolibrary.org/obo/uberon/core.owl
  • Version IRI: None
  • Loaded from: file:/__w/uberon/uberon/master/src/ontology/uberon-edit.obo

Right

  • Ontology IRI: http://purl.obolibrary.org/obo/uberon/core.owl
  • Version IRI: None
  • Loaded from: file:/__w/uberon/uberon/branch/src/ontology/uberon-edit.obo

Ontology imports

Ontology annotations

face http://purl.obolibrary.org/obo/UBERON_0001456

Removed

lip http://purl.obolibrary.org/obo/UBERON_0001833

Added

@aleixpuigb aleixpuigb closed this Jul 16, 2024
@aleixpuigb aleixpuigb deleted the 3311_lip_pat_of_face branch July 16, 2024 08:52
@aleixpuigb aleixpuigb restored the 3311_lip_pat_of_face branch July 16, 2024 08:54
@aleixpuigb aleixpuigb reopened this Jul 16, 2024
@aleixpuigb
Copy link
Collaborator Author

#gogoeditdiff

rays22
rays22 approved these changes Jul 16, 2024
View reviewed changes
Copy link
Collaborator

@rays22 rays22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me.

@aleixpuigb aleixpuigb merged commit 4e95889 into master Jul 16, 2024
2 checks passed
@aleixpuigb aleixpuigb deleted the 3311_lip_pat_of_face branch July 16, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rays22 rays22 rays22 approved these changes

@AvolaAmg AvolaAmg Awaiting requested review from AvolaAmg

@JABelfiore JABelfiore Awaiting requested review from JABelfiore

@anitacaron anitacaron Awaiting requested review from anitacaron anitacaron is a code owner

Assignees

@aleixpuigb aleixpuigb

Labels
HuBMAP uberon-classhierarchy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Lip should be part of face
2 participants
@aleixpuigb @rays22