Remove redundant injections about RO terms. #3380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are injecting several statements about RO terms that are redundant
because they correspond to axioms that are already present in upstream
RO.
Here, we remove all such injections. We also prevent the renaming of RO
terms (e.g., avoid renaming 'present in taxon' into 'present_in_taxon').
Of note, the injections on RO:0002492 ('existence ends during') were not,
in fact, redundant: we injected a somewhat simplified definition and an
exact synonym that do not exist in RO. But since we did not inject such
simplified definitions and synonyms for other similar relations (e.g.
'existence starts during'), there is no reason to do it specifically for
'existence ends during'.
Related to #2453
dosumis
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are injecting several statements about RO terms that are redundant because they correspond to axioms that are already present in upstream RO.
Here, we remove all such injections. We also prevent the renaming of RO terms (e.g., avoid renaming
present in taxonintopresent_in_taxon).Because the only logical axioms we remove all already exist in RO, this PR causes no logical change. It is merely cleaning up stuff that are (no longer) needed in Uberon.
Related to #2453