Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure the SSSOM-derived cross-reference use correct OBO prefixes. #3465

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

gouttegd
Copy link
Collaborator

Most of the prefixes used by the taxon-specific life stage ontologies (SSLSO) are not intrinsically known by ROBOT (prefixes such as BtauDv, GgalDv, PpanDv, etc.).

As a result, when the mappings from SSLSO are transformed into cross-references for injection into the ontology (when we create the mappings.owl component), the SSLSO term IDs are shortened using the only suitable prefix that ROBOT knows about, the obo: prefix.

This means that a mapping to, say, http://purl.obolibrary.org/obo/BtauDv_0000078 gets turned into a cross-reference to obo:BtauDv_0000078 -- which is, strictly speaking, correct, but not the format most people would expect for OBO-style cross-references (which would be BtauDv:0000078).

The fix is simply to make sure the prefixes are correctly declared.

Most of the prefixes used by the taxon-specific life stage ontologies
(SSLSO) are not intrinsically known by ROBOT (prefixes such as BtauDv,
GgalDv, PpanDv, etc.).

As a result, when the mappings from SSLSO are transformed into
cross-references for injection into the ontology (when we create the
`mappings.owl` component), the SSLSO term IDs are shortened using the
only suitable prefix that ROBOT knows about, the `obo:` prefix.

This means that a mapping to, say,
<http://purl.obolibrary.org/obo/BtauDv_0000078> gets turned into a
cross-reference to `obo:BtauDv_0000078` -- which is, strictly speaking,
correct, but _not_ the format most people would expect for OBO-style
cross-references (which would be BtauDv:0000078).

The fix is simply to make sure the prefixes are correctly declared.
@gouttegd gouttegd self-assigned this Jan 22, 2025
@gouttegd gouttegd requested a review from matentzn January 22, 2025 17:35
Copy link
Contributor

@matentzn matentzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you!

@gouttegd gouttegd merged commit ed81eb0 into master Jan 22, 2025
1 check passed
@gouttegd gouttegd deleted the fix-sslso-generated-xrefs branch January 22, 2025 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants