Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new edematous anatomical entity pattern template #805

Closed
2 of 3 tasks
rays22 opened this issue Mar 8, 2022 · 4 comments · Fixed by #806
Closed
2 of 3 tasks

Add new edematous anatomical entity pattern template #805

rays22 opened this issue Mar 8, 2022 · 4 comments · Fixed by #806
Assignees
Labels

Comments

@rays22
Copy link
Contributor

rays22 commented Mar 8, 2022

  1. add new pattern edematousAnatomicalEntity.yaml for review
  2. get feedback
  3. fix or improve pattern based on feedback
@rays22 rays22 self-assigned this Mar 8, 2022
rays22 added a commit that referenced this issue Mar 8, 2022
This commit intends to add a new DOSDP pattern template
`prematureClosureAnatomicalEntity.yaml`.
If applied, this commit will fix #805.
@rays22 rays22 added the pattern label Mar 8, 2022
@ybradford
Copy link
Contributor

this looks good to me. ZP uses edematous a lot for example: http://purl.obolibrary.org/obo/ZP_0000038 and http://purl.obolibrary.org/obo/ZP_0001451

It seems the ZP is already using characteristic_of which differs from XPO http://purl.obolibrary.org /obo/XPO_0141324

Orcid id 0000-0002-9900-7880

@sbello
Copy link

sbello commented Apr 21, 2022

http://www.informatics.jax.org/vocab/mp_ontology/MP:0001785

@srobb1
Copy link
Collaborator

srobb1 commented Apr 21, 2022

I definitely want to understand the implications and differences between inheres_in and characteristic_of. I use this template in PLANP and want to make sure it still works for us.

PLANP:0000801 edema in animal
PLANP:0000802 head edema
PLANP:0000803 tail edema

ORCID 0000-0002-3528-5267

@rays22
Copy link
Contributor Author

rays22 commented May 19, 2022

I definitely want to understand the implications and differences between inheres_in and characteristic_of. I use this template in PLANP and want to make sure it still works for us.

@srobb1 ,
There is no difference between inheres in and characteristic of in the sense that they both refer to RO:0000052.. characteristic of is the current label of RO:0000052. There is an explanation why the label was changed in the comment section of RO:0000052 here.

rays22 added a commit that referenced this issue May 19, 2022
If applied, this commit will fix #805.
rays22 added a commit that referenced this issue May 19, 2022
* Add edematous anatomical entity pattern template

This commit intends to add a new DOSDP pattern template
`prematureClosureAnatomicalEntity.yaml`.

* Update description, examples and contributors

If applied, this commit will fix #805.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging a pull request may close this issue.

4 participants