Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cystInLocation logical definition #878

Closed
1 task done
rays22 opened this issue Sep 9, 2022 · 1 comment · Fixed by #879
Closed
1 task done

Update cystInLocation logical definition #878

rays22 opened this issue Sep 9, 2022 · 1 comment · Fixed by #879
Assignees
Labels

Comments

@rays22
Copy link
Contributor

rays22 commented Sep 9, 2022

This is related to issue revise logical definition for Renal cyst, Pulmonary cyst etc #7484)

This change was discussed on the 9/8/2022 uPheno call and agreed that the pattern should be changed to:

'has part' some (
    'cystic' and
    ('characteristic of part of' some %s) and
    ('has modifier' some 'abnormal')
    )
@rays22 rays22 self-assigned this Sep 9, 2022
@rays22 rays22 closed this as completed in 20c79a6 Sep 9, 2022
rays22 added a commit that referenced this issue Sep 9, 2022
This commit intends to
1. Update the logical definition of cystInLocation.
2. Update ORCIDs.
3. Fix some yaml syntax errors.
If applied, this commit will fix #878.
@rays22 rays22 reopened this Sep 9, 2022
@matentzn
Copy link
Collaborator

matentzn commented Sep 9, 2022

Ok, I am not going to contradict this as the risk for the cystic pattern is super small. But generally, don't let biology dictate whether you go for "characteristic of" or "characteristic of part of". Its not a biological, its a classification concern. Think about the inferences, and if its ok that "cyst on finger" classifies under "cyst on hand" its probably ok!

rays22 added a commit that referenced this issue Sep 21, 2022
This commit intends to
1. Update the logical definition of cystInLocation.
2. Update ORCIDs.
3. Fix some yaml syntax errors.
If applied, this commit will fix #878.
rays22 added a commit that referenced this issue Sep 21, 2022
This commit intends to
1. Update the logical definition of cystInLocation.
2. Update ORCIDs.
3. Fix some yaml syntax errors.
If applied, this commit will fix #878.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging a pull request may close this issue.

2 participants