-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NTR:relationship for specifying stage of an individual #598
Comments
@dosumis any comment on this? |
Discussed at RO meeting 2022-06-28: it might be useful to spell out the modeling for the example sentence (as some object property assertions). Would this relationship be derived from a property chain involving a collection event simultaneous with an adult stage? (for example) |
Currently to say an instance of an organism has a life cycle stage, we can't use "occurs in" because "life cycle stage" is not a process per se, but rather a spatiotemporal zone that a process unfolds in? We could add "has stage" with domain organism and range life cycle stage? That would jive with common language. Then the problem that we're talking about is specimen deriving from some organism, so a shortcut relation. For maximum clarity this suggests to me shortcut would be named "has source organism stage". It seems to me life cycle stages should have associated processes, so a "biological maturity" stage would have an associated "aging in maturity" class (subclass of ageing). |
@Clare72 would this work:
(RO:0002491 "existence starts and ends with") can you say more about how you would use the relation and whether a shortcut is required? |
@Clare72 would you happen to be available on RO call Tues Jan 31 to address this? Issue is on agenda: http://bit.ly/ro-minutes |
ok |
processual entity -> "life cycle stage" doesn't follow aristotelean format Jie: let "life cycle stage" (UBERON) .. be a process Damion will work on draft definition for: |
label: at life cycle stage Question: Should COB adopt CARO "anatomical entity" to cover the disjunction of cell, gross anatomical part, or organism. Defn could be tweaked: "Biological entity that is either an individual member of a biological species or constitutes part of the structural organization of an individual member of a biological species. " |
I'm pretty confused by this issue At first we were talking about relating a sample to a stage at which the organism was at, in which case I agree with @ddooley that a shortcut relation chaining derives_from and (simultaneous_with or the relevant anatomical structure to stage relationships). But if we are talking about relating the anatomical structure to the stage is this not covered in #611? Additional points:
|
Discussed on Feb 28 call. Jie likes: has life cycle stage as a more specific relation than "participates in". This establishes a relationship at class level so organism class N has life cycle stages X,Y,Z. label: has life cycle stage We also introduce "at life cycle stage" for instance data, indicating that a particular organism (or sample deriving from it) was at a given stage when collected. label: at life cycle stage Pending further comments, I will make a pull request for these object properties. |
For "at life cycle stage" definition, given its an output of specimen collection process, I think the label should be specialized to mention "specimen" too. label: specimen at life cycle stage' and definition too: BTW, I can imagine biologists might like to say something specific about an instance of an organism in a life cycle stage but not imply anything necessarily about sample collection. I think they can use the "has life cycle stage" at the instance level for this. |
Do you think the label |
I like your 2nd label best! |
@wdduncan are you the giver-outer of RO ids? I will mint some with a pull request. Also can I be a RO collaborator? (Otherwise it seems my obo-relations repo seems to be 1 step removed, and I don't quite know how to sync master over time.) |
Hah! I had no idea that I had this role :)
|
So I see the id range pull request is ready to merge. Shall I? I can't remember how to do a ro "make" locally on my computer to try my ro-edit.owl changes on? I have to trigger new OBI "sample from organism", and UBERON "life cycle stage" as imports before I can add them to ranges. I was trying "sh run.sh make release" per README-editors.md but that generates an error: "make: *** No rule to make target 'release'. Stop." - maybe docs need updating. I tried sh run.sh make update-uberon and that worked! |
Do you mean Yes, the docs need updates to add the ODK approach. |
Ah yes that was it, refresh-uberon. |
So further RO discussion gave the go-ahead to "has life cycle stage" and its inverse, which I have added as "live cycle stage of" in the pull request. Discussion led to wanting to drop "specimen at life cycle stage" if there was another possible existing RO relation that covers this situation. I'm seeing an RO "existence starts during" which is a subclass of "relation between physical entity and a process or stage" defn. "... a diverse set of relations, typically connecting an anatomical entity to a biological process or developmental stage." So we could say "specimen [x] "existence starts during" [life stage]"?! Is that fudging it? Here we're talking about the existence of the specimen, rather than the morphological part the specimen derived from. Seems like that semantic is consistent. We can also add other statements such as "specimen [x] 'has taxon' some taxon [y]" and maybe helpfully add that "specimen [x] 'derives from' [anatomical part]". |
Chris M. suggests 'collected during'. Damion will make a PR. |
Discussion revolved around wanting to shy away from reuse of "existence starts during" which is talking about in-place (in silico) development stage temporality, vs extracted material, and secondly generalizing the relationship to cover any processual entity, not just life cycle stages. So "collected during" would cover this generally! |
Added "collected during" pull request #759 . But what is its reverse? "Occured while collecting" ? [occurent] occured while collecting material [material entity]? |
Perhaps add "developmental stage" to end of label -> "collected during developmental stage". Inverse would be: "developmental stage when collected" Too wordy? |
We wanted to back off the specificity of having this relation attach to developmental stage. Instead it would just pertain to any occurrent, so other circumstances during which the specimen was collected, e.g. high tide. Ok? |
Ah yes ... Sorry ... brain cramps ... Now I seem to recall the conversation. |
I apologize. But, I can't recall what the issue was with |
Thanks for figure @ddooley ! I like the figure :) Should
Random thoughts:
Just a comment about process and life cycle stages (mentioned above): |
Another potential label for a more general relation between a material entity and occurrent: |
Hmm. "collection process" is a planned process, so "has specified output" is acceptable. But I'm fine checking with the group about simplifying to "has input/output". At moment I vaguely recall issue is that "has specified input / output" can't be a sub-property of "has input/output" which then leads to conflict, but maybe that's getting resolved in COB? If you propose changing label of "happens during" lets do that in another thread since that's an existing relationship. Same with NTR "existence occurs in". I was wondering if there was a more generic term for "collected". Collected does convey intentionality, and hints at a goal - a collection of things. "Obtained" perhaps, leaving vague about how obtained, and if destined for a collection. "Selected" perhaps, but it doesn't imply possible extraction steps involved. Acquired can imply money exchange. Gathered almost implies gathering by hand; accrued implies accruing over time. |
Not sure what the right path is here. Neither planned process or specified input relations are in RO. So, he relations seems really specific to OBI. We can add it to RO, but would not be able to define the domain, range, or property chain. We (in RO) need to get a better idea on what should be in RO and what should be left to other ontologies. E.g., Do we want all new relations defined in OBO ontologies to be in RO? I have mixed thoughts about this. Question: Since this seems to be a very OBI specific relation, why do you think it should be in RO? |
Well, I am in favour of all relations being in RO for domain/range consistency, but I can see that could run into trouble as one gets deeper into sub-properties. At any rate, the relation "collected during" doesn't have any dependencies directly on OBI classes. A property chain would be nice but that can come later if/when RO does have all relations. |
Yes, it can have domain:material entity and range:occurent. This would be very general and may not satisfy you in the sense that it won't be possible to verify if a collection process was involved. But, if that is fine with you, it is fine with me. I'll have to think about whether I want to submit an NTR for |
I remember now, that "collected during" range "occurent" allows us to say both the collection process, AND to reference other events related to the sample collection time, e.g. "collected during 'low tide'" |
Lots of debate about the what things like 'low tide', 'adult stage', etc. are. Though not perfect, I classify such things as processes or subprocesses within a larger process. E.g., Low tide the subprocess of the larger tidal process during which the water level was at the low point. Again, not perfect, but stays away from having to also model temporal regions (and the like). |
From RO call:
|
Current 'existence overlaps' relationship is weird for an individual sample taken from an organism at a particular stage.
I think what we need is a 'has stage' relationship to capture the stage of life than an entity is currently in.
label: 'has stage'
definition: "A relationship between an anatomical entity and its current stage of life."
example of usage: "A tissue sample collected during the adult stage 'has stage' some 'adult stage'."
@dosumis
The text was updated successfully, but these errors were encountered: