Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename "exposure event or process" to "exposure of organism" #599

Closed
wdduncan opened this issue Apr 6, 2022 · 5 comments · Fixed by #606
Closed

rename "exposure event or process" to "exposure of organism" #599

wdduncan opened this issue Apr 6, 2022 · 5 comments · Fixed by #606
Labels
change request Request to change a relation, property, hierarchy, etc. environment Related to environment or ecology

Comments

@wdduncan
Copy link
Collaborator

wdduncan commented Apr 6, 2022

In ECTO, there is an exposure event class. However, due to the RO import, the class exposure event or process exists. It would be helpful and less confusing if ECTO used the same class as RO for these events. Would you be willing to change label for exposure event or process to simply be exposure event?

I am also going to see exposure event can be added to COB.

cc @nicolevasilevsky @laurenechan @diatomsRcool @cmungall

@nicolevasilevsky
Copy link
Contributor

I don't have any objections but this is really up to @diatomsRcool.

@wdduncan
Copy link
Collaborator Author

wdduncan commented Apr 6, 2022

Another suggestion may be for RO to use the ECTO class exposure event for the domain constraint. However, that may break existing usages.

@cmungall
Copy link
Contributor

cmungall commented Apr 8, 2022

We should obsolete the RO class and use an ECTO or COB class (not ExO). classes are only in RO as placeholders.

@diatomsRcool
Copy link
Contributor

I'm fine with changing the label.
FYI - If memory serves the "event or process" was used to emphasize that an exposure event was a type of BFO process. There was a lot of discussion about event vs process.

@nlharris nlharris added environment Related to environment or ecology change request Request to change a relation, property, hierarchy, etc. labels May 3, 2022
@wdduncan wdduncan changed the title rename "exposure event or process" to "exposure event" rename "exposure event or process" to "exposure of organism" Aug 18, 2022
@wdduncan
Copy link
Collaborator Author

COB has added an exposure of organism class.

Waiting on new release of COB before using this class.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
change request Request to change a relation, property, hierarchy, etc. environment Related to environment or ecology
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants