-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rename "exposure event or process" to "exposure of organism" (issue 599) #606
Conversation
wdduncan
commented
May 2, 2022
- add exposure event class
- change domain of 'related via exposure to' to 'exposure event'
- obsolete 'exposure event or process'
Fixes #599 @matentzn @diatomsRcool @laurenechan @cmungall The goal of this PR is to fix the confusion created by having both It also relates to COB issue OBOFoundry/COB#192. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We recommend the ECTO group mint an ID for exposure event for now, with the understanding it may be deprecated and replaced by a COB class eventually
We will then replace the usage of the current RO class in domains and ranges with the ECTO URI (and later with the COB URI)
COB has added the class |
@cmungall This is being held up b/c we are waiting on new release of COB. Are you the only one who release COB? Can you assign some else? |
This PR has not seen any activity in 90 days and has been marked as stale. If it is no longer needed, please close the PR. Otherwise, please update the PR with a status update. |
Update: The COB class needed is ready. I just need to find the time to circle back to this. |
This PR has not seen any activity in 90 days and has been marked as stale. If it is no longer needed, please close the PR. Otherwise, please update the PR with a status update. |
@anitacaron I've been holding of on this until the COB is ready so that I can use the COB class. |
@wdduncan, Do you need help fixing the conflicts in the ro-edit.owl? |
@anitacaron I don't think there will be any conflicts (I hope). |
There's already a conflict in this branch, but I'll wait for you to add the COB term. Do you need help importing COB? |
Just an update: |
COB is already ready to use. It was merged in PR #736. I can fix the conflict in the edit file. |
@anitacaron Your help would be greatly appreciated! :) |
This PR has not seen any activity in 90 days and has been marked as stale. If it is no longer needed, please close the PR. Otherwise, please update the PR with a status update. |
This has been open for quite a while. I need to review to see what needs to be done in order to finish. |
Still working on this. |
@anitacaron @cmungall The IRI has been changed to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Label and IRI has been updated. Old creator annotation has been removed.
Can finish this up?
This PR has not seen any activity in 90 days and has been marked as stale. If it is no longer needed, please close the PR. Otherwise, please update the PR with a status update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically, it's approved. It still needs an ontology review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Previous review from May 2022 was to hold this PR until COB term is available. I confirm the COB term was imported correctly in this PR.