Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NTR: supplies blood to; drains blood from #699

Closed
dosumis opened this issue Mar 21, 2023 · 15 comments · Fixed by #782
Closed

NTR: supplies blood to; drains blood from #699

dosumis opened this issue Mar 21, 2023 · 15 comments · Fixed by #782

Comments

@dosumis
Copy link
Contributor

dosumis commented Mar 21, 2023

Make new subproperties of supplies/drains: "supplies blood to" / "drains blood from" with domains 'arterial blood vessel' and 'venous blood vessel'' respectively (these classes cover the microvasculature as well as arteries and veins.).

Background: These will replace usage of supplies and drains in Uberon, where they have been used extensively but with domain and range added locally - illegally restricting the meaning of these relations & being the the potential source of problematic inferences where drains and supplies are used outside of an anatomical context (e.g. for rivers).

@cthoyt
Copy link
Collaborator

cthoyt commented Mar 21, 2023

does this apply to ticks, mosquitos, and/or vampires?

@dosumis
Copy link
Contributor Author

dosumis commented Mar 21, 2023

I guess tempting to 'drains blood from' for feeding ticks, mosquitos and vampires, but domain restricts it to vertebrate(?) veinous vessels (veins, venules)

@ghost
Copy link

ghost commented Mar 22, 2023

Of note- this issue is dependent on the completion of #695 as there is currently no Uberon import to RO. Without the import, the requested domains can not fully be added.

@wdduncan
Copy link
Collaborator

I've submitted #701 to address consistency for domains and/or ranges.

@wdduncan
Copy link
Collaborator

Notes for RO Call:

Are just intending to constrain the current RO drains so that it only involves blood? If so, are you okay with syringe also being used with this relation?

Label suggestion: vessel drains blood / vessel supplies blood

@dosumis
Copy link
Contributor Author

dosumis commented Jun 20, 2023

Decision punted to @cmungall :

Either
(a) - Roll back from all this complexity and just promote much more general use of drains and supplies. I just reviewed a bunch of tickets on drains/supplies/channels - I worry that the complexity is unsustainable. There is a very small amount of positive inference in Uberon coming from the domain of each of these terms (a hand full of inferences) but it would be no big deal to add these manually. The downside is losing some consistency checking in Uberon, but are we really that worried about these being used for something dumb? The inconsistencies we have found all look defensible to me if we allow for a more general usage/meaning (e.g draining calyces of the kidney).
(b) Add as requested but with more specific names - 'vessel drains blood' & 'vessel supplies blood'. These were requested in the RO call as without them drains_blood might be applies to medical devices or mosquitos.

@wdduncan
Copy link
Collaborator

Any update on this?

@cmungall
Copy link
Contributor

I favor b, with names "vessel for draining blood from" and "vessel for supplying blood to"

or another naming convention that might be more scalable is "(domain) genericRelation (range)" [including the parentheses]

E.g. "(vessel) drains (blood)"

I am wondering if we want to revise the shoreline and just include these in uberon with uberon IDs They are not reusable outside uberon or a descendant of uberon (e.g ZFA). This feels more modular.

@wdduncan
Copy link
Collaborator

I like the naming convention (domain) genericRelation (range), but I worry it will be off putting to user.

@wdduncan
Copy link
Collaborator

Note: (vessel) drains (blood) does not contain "from" or "to". So, it may not be clear what the intent is.

E.g.:
(vessel) for draining (blood) from
However, if "(blood)" is the domain indicated by this syntactic convention, it obfuscates that there is an organ from which the blood is being drained.

To make this more specific you would something like:
(vessel) for draining blood from (organ)

This seems awkward. Perhaps that may be of use for more general relations.

The sentiment on RO call is to not implement the syntactic convention.

Minor suggestion is to add an "is" to the front of the label:
"is vessel for draining blood from" and "is vessel for supplying blood to"

Another suggestion is to define a general vessel drains relation and then check for consistency using GCIs in UBERON.

@balhoff
Copy link
Member

balhoff commented Jul 18, 2023

Can Uberon folks provide an example of the consistency checking that would be lost by just using the existing RO drains? There may be a reasonable way to implement the constraints in Uberon using GCIs or rolification.

@cmungall
Copy link
Contributor

cmungall commented Aug 3, 2023

I would like to avoid adding more things that are hard to mentally reason about. I think the decision to use specific relations is a good one. We can include a more specific and anatomically relevant text definition, examples, and other metadata. There are many other characteristics that separate rivers from blood vessels.

We do need to address design patterns of genericity and specificity more broadly across RO, but we should do this in another ticket.

@ghost
Copy link

ghost commented Sep 5, 2023

Checking in on this ticket.
Is there consensus on creating new Uberon terms as suggested here with no change in RO?

@allenbaron
Copy link

The use of supplies/drains as a general property could get confusing in the case of something where multiple different substances are supplied or drained. Even limiting to liquids in anatomy the example of the 'urinary bladder' demonstrates this. In Uberon v2023-12-08, the 'urinary bladder' is currently listed with a "supplies" axiom from 'superior vesical artery' and a "drains" axiom from 'vesical vein'. That's fine for blood but what about urine which is also supplied to and drained from it?

@jamesamcl
Copy link

In the interest of getting things moving here as it has been 10+ months, I spoke to @cmungall about this. We have agreed the best plan of action is to create specific relations, but to keep them in RO as we already have very specific relations here.

anitacaron pushed a commit that referenced this issue Feb 6, 2024
* Add supplies and drains with domain vessel

* Change label and add punctuation

* Add range and domain

* Add examples

* Improve definition

* Remove 'blood vessel' from ro-edit.owl

* Update directly_supplies_drains

Updates label to 'directly supplies and drains', the domain is capillary (imported) and is a subproperty of 'supplies' and 'drains'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants