-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NTR: supplies blood to; drains blood from #699
Comments
does this apply to ticks, mosquitos, and/or vampires? |
I guess tempting to 'drains blood from' for feeding ticks, mosquitos and vampires, but domain restricts it to vertebrate(?) veinous vessels (veins, venules) |
Of note- this issue is dependent on the completion of #695 as there is currently no Uberon import to RO. Without the import, the requested domains can not fully be added. |
I've submitted #701 to address consistency for domains and/or ranges. |
Notes for RO Call: Are just intending to constrain the current RO drains so that it only involves blood? If so, are you okay with syringe also being used with this relation? Label suggestion: |
Decision punted to @cmungall : Either |
Any update on this? |
I favor b, with names "vessel for draining blood from" and "vessel for supplying blood to" or another naming convention that might be more scalable is "(domain) genericRelation (range)" [including the parentheses] E.g. "(vessel) drains (blood)" I am wondering if we want to revise the shoreline and just include these in uberon with uberon IDs They are not reusable outside uberon or a descendant of uberon (e.g ZFA). This feels more modular. |
I like the naming convention |
Note: E.g.: To make this more specific you would something like: This seems awkward. Perhaps that may be of use for more general relations. The sentiment on RO call is to not implement the syntactic convention. Minor suggestion is to add an "is" to the front of the label: Another suggestion is to define a general |
Can Uberon folks provide an example of the consistency checking that would be lost by just using the existing RO drains? There may be a reasonable way to implement the constraints in Uberon using GCIs or rolification. |
I would like to avoid adding more things that are hard to mentally reason about. I think the decision to use specific relations is a good one. We can include a more specific and anatomically relevant text definition, examples, and other metadata. There are many other characteristics that separate rivers from blood vessels. We do need to address design patterns of genericity and specificity more broadly across RO, but we should do this in another ticket. |
Checking in on this ticket. |
The use of supplies/drains as a general property could get confusing in the case of something where multiple different substances are supplied or drained. Even limiting to liquids in anatomy the example of the 'urinary bladder' demonstrates this. In Uberon v2023-12-08, the 'urinary bladder' is currently listed with a "supplies" axiom from 'superior vesical artery' and a "drains" axiom from 'vesical vein'. That's fine for blood but what about urine which is also supplied to and drained from it? |
In the interest of getting things moving here as it has been 10+ months, I spoke to @cmungall about this. We have agreed the best plan of action is to create specific relations, but to keep them in RO as we already have very specific relations here. |
* Add supplies and drains with domain vessel * Change label and add punctuation * Add range and domain * Add examples * Improve definition * Remove 'blood vessel' from ro-edit.owl * Update directly_supplies_drains Updates label to 'directly supplies and drains', the domain is capillary (imported) and is a subproperty of 'supplies' and 'drains'
Make new subproperties of supplies/drains: "supplies blood to" / "drains blood from" with domains 'arterial blood vessel' and 'venous blood vessel'' respectively (these classes cover the microvasculature as well as arteries and veins.).
Background: These will replace usage of supplies and drains in Uberon, where they have been used extensively but with domain and range added locally - illegally restricting the meaning of these relations & being the the potential source of problematic inferences where drains and supplies are used outside of an anatomical context (e.g. for rivers).
The text was updated successfully, but these errors were encountered: