Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more property chains over in taxon #831

Open
gouttegd opened this issue Feb 21, 2025 · 0 comments · May be fixed by #832
Open

Add more property chains over in taxon #831

gouttegd opened this issue Feb 21, 2025 · 0 comments · May be fixed by #832
Assignees
Labels
change request Request to change a relation, property, hierarchy, etc.

Comments

@gouttegd
Copy link
Collaborator

gouttegd commented Feb 21, 2025

Uberon currently injects a bunch of property chains over 'in taxon', so that the property holds over the following other properties:

Those chains are critical to the proper functioning of the taxon constraints.

Both 'in taxon' and all the aforementioned properties are defined by RO, so any property chain over them should also be defined in RO and not in any downstream ontology.

Importantly, the fact that those chains are defined solely in Uberon means that taxon constraints are computed differently in Uberon than in other ontologies (e.g. in CL). For example, if an anatomical entity A1 in Uberon is 'developmentally induced by' by another entity A2 that is specific to a taxon T, then A1 can be inferred to be specific to T, but if a cell C1 in the Cell Ontology is 'developmentally induced by' the same entity A2, C1 will not be inferred to be specific to T (or rather, whether it will be inferred to be specific to T or not will depend on what you import and how; CL imports a base version of Uberon that does not include those chains, so in CL itself the inference will not be made).

So I propose upstreaming all those chains to RO, and use that opportunity to generalise them.

For example, instead of of several chains over 'attached to', 'connected to', 'connects', 'continuous with', and 'overlaps' (which would be added to the already existing chains in RO over 'part of' and 'has part'), I suggest a single chain over 'mereotopologically related to'.

Likewise, I suggest a single chain over 'developmentally related to' instead of several chains over 'developmentally induced by' (upstreamed from Uberon) and 'has potential to develop into' and 'results in developmental progression of' (already existing in RO).

Likewise, a single chain over 'relation between physical entity and a process or stage' instead of separate chains over 'existence ends during' and 'existence starts during'.

@gouttegd gouttegd self-assigned this Feb 21, 2025
@gouttegd gouttegd added the change request Request to change a relation, property, hierarchy, etc. label Feb 21, 2025
gouttegd added a commit that referenced this issue Feb 21, 2025
This commit adds several property chains of the form

  X o 'in taxon' SubPropertyOf: 'in taxon'

where X represents the following properties:

* 'mereotologically related to' (RO:0002323),
* 'developmentally related to' (RO:0002324),
* 'relation between physical entity and a process or stage' (RO:0002487),
* 'innervated_by' (RO:0002005),
* 'innvervates' (RO:0002134),
* 'produced by' (RO:0003001),
* 'produces' (RO:0003000).

Existing property chains over properties that are subproperties of those
listed above (e.g. 'part of', BFO:0000050) are removed since they are no
longer necessary.

closes #831
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
change request Request to change a relation, property, hierarchy, etc.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant