Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added links to go fixes #678 #679

Merged
merged 3 commits into from
Feb 24, 2023
Merged

added links to go fixes #678 #679

merged 3 commits into from
Feb 24, 2023

Conversation

pgaudet
Copy link
Collaborator

@pgaudet pgaudet commented Feb 21, 2023 •
edited by matentzn
Loading

Fixes #678

@pgaudet pgaudet requested a review from balhoff February 21, 2023 08:06
@matentzn
Copy link
Contributor

Please do not merge this PR right now, I have a big conflicting PR open (#492); I will deal with reconciling the two @pgaudet, but it would be great if we could hold off on further PRs until #492 is merged, cc @cmungall

Sorry about that, but will be dealt with in a the next 48 hours

@pgaudet
Copy link
Collaborator Author

pgaudet commented Feb 21, 2023

No worries - AFAIK I dont have permission to merge ;)

matentzn
matentzn requested changes Feb 22, 2023
View reviewed changes
src/ontology/ro-edit.owl Outdated Show resolved Hide resolved
src/ontology/ro-edit.owl Show resolved Hide resolved
@pgaudet @matentzn
Update src/ontology/ro-edit.owl
8ba79a1 
Co-authored-by: Nico Matentzoglu <nicolas.matentzoglu@gmail.com>
@pgaudet
Copy link
Collaborator Author

pgaudet commented Feb 22, 2023

I made the requested change. Let me know if you spot other problems.

Thanks, Pascale

matentzn
matentzn approved these changes Feb 22, 2023
View reviewed changes
Copy link
Contributor

@matentzn matentzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent looks good. Ready for
Merge!

@cmungall cmungall merged commit 9eb72f8 into master Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matentzn matentzn matentzn approved these changes

@balhoff balhoff Awaiting requested review from balhoff

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add links to GO relations documentation
3 participants
@pgaudet @matentzn @cmungall