Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure provenance relations are used with ORCID or other appropriate IRIs #690

Merged
merged 10 commits into from
Mar 1, 2023

Conversation

cthoyt
Copy link
Collaborator

@cthoyt cthoyt commented Feb 28, 2023

This check should ensure that IAO:0000117 (term editor), dc:contributor, dc:creator, and oio:created_by all have appropriate ORCID/Wikidata/ROR IRIs. I also did all of the curation it took to pass this check.

This is based on @anitacaron's suggestion from UBERON/CL: https://github.com/obophenotype/uberon/blob/master/src/sparql/orcid-contributor-violation.sparql

@cthoyt cthoyt changed the title Add report that IAO:0000117 is exclusively used with IRIs Ensure provenance relations are used with ORCID or other appropriate IRIs Feb 28, 2023
@cthoyt cthoyt marked this pull request as ready for review February 28, 2023 21:43
@cmungall
Copy link
Contributor

cmungall commented Mar 1, 2023

Thanks @cthoyt !

This makes ro statistics look much cleaner:

...
  orcid:0000-0002-6601-2165:
    contributor_id: orcid:0000-0002-6601-2165
    role_counts:
      IAO:0000117:
        facet: IAO:0000117
        filtered_count: 260
      dcterms:contributor:
        facet: dcterms:contributor
        filtered_count: 2
      dcterms:creator:
        facet: dcterms:creator
        filtered_count: 7
      oio:created_by:
        facet: oio:created_by
        filtered_count: 46
  orcid:0000-0002-7073-9172:
    contributor_id: orcid:0000-0002-7073-9172
    role_counts:
      IAO:0000117:
        facet: IAO:0000117
        filtered_count: 38
      dcterms:contributor:
        facet: dcterms:contributor
        filtered_count: 1
      oio:created_by:
        facet: oio:created_by
        filtered_count: 15
...

I would like to also normalize on dcterms:contributor (see information-artifact-ontology/ontology-metadata#120 where I was convinced of this). But this can be a separate PR! onwards!

@matentzn matentzn merged commit 5a8ab53 into oborel:master Mar 1, 2023
@cthoyt cthoyt deleted the add-editor-violations branch March 1, 2023 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants