-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure provenance relations are used with ORCID or other appropriate IRIs #690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cthoyt
commented
Feb 28, 2023
cthoyt
changed the title
Add report that
Ensure provenance relations are used with ORCID or other appropriate IRIs
Feb 28, 2023
IAO:0000117
is exclusively used with IRIs
Thanks @cthoyt ! This makes ...
orcid:0000-0002-6601-2165:
contributor_id: orcid:0000-0002-6601-2165
role_counts:
IAO:0000117:
facet: IAO:0000117
filtered_count: 260
dcterms:contributor:
facet: dcterms:contributor
filtered_count: 2
dcterms:creator:
facet: dcterms:creator
filtered_count: 7
oio:created_by:
facet: oio:created_by
filtered_count: 46
orcid:0000-0002-7073-9172:
contributor_id: orcid:0000-0002-7073-9172
role_counts:
IAO:0000117:
facet: IAO:0000117
filtered_count: 38
dcterms:contributor:
facet: dcterms:contributor
filtered_count: 1
oio:created_by:
facet: oio:created_by
filtered_count: 15
... I would like to also normalize on dcterms:contributor (see information-artifact-ontology/ontology-metadata#120 where I was convinced of this). But this can be a separate PR! onwards! |
cmungall
approved these changes
Mar 1, 2023
matentzn
approved these changes
Mar 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This check should ensure that
IAO:0000117
(term editor),dc:contributor
,dc:creator
, andoio:created_by
all have appropriate ORCID/Wikidata/ROR IRIs. I also did all of the curation it took to pass this check.This is based on @anitacaron's suggestion from UBERON/CL: https://github.com/obophenotype/uberon/blob/master/src/sparql/orcid-contributor-violation.sparql