-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NTR: owns; is owned by #705
Conversation
@mbrochhausen @CDowland @zhengj2007 I've add the terms. Who do you suggest to review? |
I recommended @mbrochhausen. |
@wdduncan Could you also use the inverse of axiom to indicate that owns is inverse relation of 'is owned by' and vice versa? Besides, here is the definition of OBIB:0000735 is owned by in OBIB: |
@zhengj2007 I added the As for the definition of Also, "complete power" seems a bit strong. I own my dog, but I don't have complete power over him. |
@wdduncan I need to change the IRI. This PR has been open so long that I forgot about it, and accidentally used the IRI. |
This PR has not seen any activity in 90 days and has been marked as stale. If it is no longer needed, please close the PR. Otherwise, please update the PR with a status update. |
I think this is ready. @CDowland What do you think? |
@wdduncan I did a review/approval yesterday as requested, but it's still showing that another is required. It says "reviewers with write access," which I don't think includes me. |
@cthoyt @balhoff @zhengj2007 @cmungall @matentzn @jamesaoverton @lschriml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
besides the spurious diffs, it looks fine
@wdduncan Could you please update the dcterms:source for 'owns'? It should be OBIB:0000732. Since I was not assigned as the reviewer, I cannot review and approve the request. |
Based on the OBIB discussion, we do not need the DCterms: source. |
@zhengj2007 can you please approve this PR. |
@wdduncan Could you please assign me as a reviewer? Thanks! |
@zhengj2007 I can't add you as a reviewer. It seems that you are not a member of obo-rel repo ... sorry I thought you were. @anitacaron Can I add her so that she can review this PR? If so, what level of permissions does Jie need? |
@wdduncan I added @zhengj2007 with a 'write' role; we need to wait for her to accept the invite to add her as a reviewer here. |
Thanks @anitacaron! |
@anitacaron Thanks for invitation. |
Thanks Jie. I assigned you as a reviewer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wdduncan According to Mathias' comments: "Based on the OBIB discussion, we do not need the DCterms: source.", RO may remove "DCterms: source" annotations associated with 'owns' and 'is owned by'. If RO prefers to keep the DCterms: source annotation to reference OBIB terms, it need to change "DCterms: source OBIB:0000735" to "DCterms: source OBIB:0000732" to term RO:0017008 'owns'.
@zhengj2007 I believe @mbrochhausen said that the AFAIK, |
@wdduncan Yes. However, it is still in ro-edit.owl. So, it should be either removed or corrected if you want to keep it. |
Ah ... okay. Sorry @zhengj2007 I misunderstood you :) I removed the |
@wdduncan There is dcterms:source associated with 'owns' need to be removed too. |
Thanks @zhengj2007! |
Actually 4 reviewers approved this pull request. Don't know why it only shows 1 approval. |
Fixes #674