fix: composite mcp servers #5027
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a new controller handler for composite `MCPServer`s that deletes component `MCPServers` and `MCPServerInstances` when: - the component is a non-latest duplicate - the catalog entry or server referenced by the component isn't referenced in the composite config Signed-off-by: Nick Hale <4175918+njhale@users.noreply.github.com>
The `RemoteCatalogConfig` type contains fields necessary for editing the configuration of a running remote MCP server. Today, the configuration constraints are always taken directly from the catalog entry, which can change post-launch. This means that when a catalog is updated, the running remote MCP servers referencing it are automatically updated, bypassing the normal upgrade flow for MCP servers. This was also an issue for changes to composite MCP catalog entries. As a part of fixing this, update the type definition of `RemoteRuntimeConfig` so that it embeds `RemoteCatalogConfig`. Note: In addition to this change, we'll need to implement some migration logic to populate the fields from the current catalog entries where possible. Signed-off-by: Nick Hale <4175918+njhale@users.noreply.github.com>
Signed-off-by: Nick Hale <4175918+njhale@users.noreply.github.com>
Signed-off-by: Nick Hale <4175918+njhale@users.noreply.github.com>
- Use new `ComponentID` method - Drop unused PU scope capture (admin only in the default catalog) Signed-off-by: Nick Hale <4175918+njhale@users.noreply.github.com>
Signed-off-by: Nick Hale <4175918+njhale@users.noreply.github.com>
Signed-off-by: Nick Hale <4175918+njhale@users.noreply.github.com>
Signed-off-by: Nick Hale <4175918+njhale@users.noreply.github.com>
Signed-off-by: Nick Hale <4175918+njhale@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a large bundle of fixes in progress
Aims to address:
update requiredcontinues to be present after save is done (until manual refresh) #4929Updatepicks up changes done to existing individual mcpserver (which should be picked only byUpgradeaction) #4982