No alias wait #736
Merged
No alias wait #736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change introduces a small paradigm change in how aliases are handled. The AliasAssigned field is not a pointer that is only set once we know that the alias controller has processed the object. A caller can check for nil versus false to determine whether the controller has process the object and the alias will not be assigned. Signed-off-by: Donnie Adams <donnie@acorn.io>
The resolved field exposes whether the controller has resolved the tool reference and the fields are up to date. Signed-off-by: Donnie Adams <donnie@acorn.io>
thedadams
force-pushed
the
no-alias-wait
branch
from
aa361bf to
84286b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.