Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: RunSpec.Timeout to override default 10m run timeout #755

Merged
merged 2 commits into from
Dec 4, 2024

Conversation

iwilltry42
Copy link
Contributor

@iwilltry42 iwilltry42 commented Dec 4, 2024

... also set default knowledge data-source sync timeout to 30m 1h, as it can easily happen that website-scraping exceeds 10 minutes.

Ref https://github.com/otto8-ai/otto8/issues/743

Copy link
Contributor

@cjellick cjellick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one small tweak

Copy link
Contributor

@StrongMonkey StrongMonkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with craig's comment addressed

@iwilltry42 iwilltry42 requested a review from cjellick December 4, 2024 18:38
@iwilltry42 iwilltry42 merged commit 0616610 into obot-platform:main Dec 4, 2024
@iwilltry42 iwilltry42 deleted the change/run-timeout branch December 4, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants