Refactor visual brainstorming: browser displays, terminal commands#509
Merged
Refactor visual brainstorming: browser displays, terminal commands#509
Conversation
Replaces the blocking TaskOutput/wait-for-feedback.sh pattern with a
non-blocking model where the browser is an interactive display and the
terminal stays available for conversation.
Server changes:
- Write user click events to .events JSONL file (per-screen, cleared on
new screen push) so Claude reads them on its next turn
- Replace regex-based wrapInFrame with <!-- CONTENT --> placeholder
- Add --foreground flag to start-server.sh for sandbox environments
- Harden startup with nohup/disown and liveness check
UI changes:
- Remove feedback footer (textarea + Send button)
- Add selection indicator bar ("Option X selected — return to terminal")
- Narrow click handler to [data-choice] elements only
Skill changes:
- Rewrite visual-companion.md for non-blocking loop
- Fix visual companion being skipped on Codex (no browser tools needed)
- Make visual companion offer a standalone question (one question rule)
Deletes wait-for-feedback.sh entirely.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The visual companion was a disconnected section at the bottom of SKILL.md that agents never reached because it wasn't in the mandatory checklist. Now step 2 evaluates whether the topic involves visual/UX decisions and offers the companion if so. Non-visual topics (APIs, data models, etc.) skip the step entirely. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Containers with data-multiselect allow toggling multiple selections. Without it, behavior is unchanged (single-select). Indicator bar shows count when multiple items are selected. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Collaborator
Author
|
This change is part of the following stack: Change managed by git-spice. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor visual brainstorming: browser displays, terminal commands
Replaces the blocking TaskOutput/wait-for-feedback.sh pattern with a
non-blocking model where the browser is an interactive display and the
terminal stays available for conversation.
Server changes:
new screen push) so Claude reads them on its next turn
UI changes:
Skill changes:
Deletes wait-for-feedback.sh entirely.
Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com
Add visual companion offer to brainstorming checklist for UX topics
The visual companion was a disconnected section at the bottom of SKILL.md
that agents never reached because it wasn't in the mandatory checklist.
Now step 2 evaluates whether the topic involves visual/UX decisions and
offers the companion if so. Non-visual topics (APIs, data models, etc.)
skip the step entirely.
Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com
Add multi-select support to visual companion
Containers with data-multiselect allow toggling multiple selections.
Without it, behavior is unchanged (single-select). Indicator bar shows
count when multiple items are selected.
Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com
tweaks for codex browser spawn, guidance on when to viz
Motivation and Context
How Has This Been Tested?
Breaking Changes
Types of changes
Checklist
Additional context