Skip to content

Comments

Refactor visual brainstorming: browser displays, terminal commands#509

Merged
obra merged 6 commits intodevfrom
viz-brain-refactor
Feb 20, 2026
Merged

Refactor visual brainstorming: browser displays, terminal commands#509
obra merged 6 commits intodevfrom
viz-brain-refactor

Conversation

@arittr
Copy link
Collaborator

@arittr arittr commented Feb 19, 2026

Refactor visual brainstorming: browser displays, terminal commands

Replaces the blocking TaskOutput/wait-for-feedback.sh pattern with a
non-blocking model where the browser is an interactive display and the
terminal stays available for conversation.

Server changes:

  • Write user click events to .events JSONL file (per-screen, cleared on
    new screen push) so Claude reads them on its next turn
  • Replace regex-based wrapInFrame with placeholder
  • Add --foreground flag to start-server.sh for sandbox environments
  • Harden startup with nohup/disown and liveness check

UI changes:

  • Remove feedback footer (textarea + Send button)
  • Add selection indicator bar ("Option X selected — return to terminal")
  • Narrow click handler to [data-choice] elements only

Skill changes:

  • Rewrite visual-companion.md for non-blocking loop
  • Fix visual companion being skipped on Codex (no browser tools needed)
  • Make visual companion offer a standalone question (one question rule)

Deletes wait-for-feedback.sh entirely.

Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com

Add visual companion offer to brainstorming checklist for UX topics

The visual companion was a disconnected section at the bottom of SKILL.md
that agents never reached because it wasn't in the mandatory checklist.
Now step 2 evaluates whether the topic involves visual/UX decisions and
offers the companion if so. Non-visual topics (APIs, data models, etc.)
skip the step entirely.

Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com

Add multi-select support to visual companion

Containers with data-multiselect allow toggling multiple selections.
Without it, behavior is unchanged (single-select). Indicator bar shows
count when multiple items are selected.

Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com

tweaks for codex browser spawn, guidance on when to viz

Motivation and Context

How Has This Been Tested?

Breaking Changes

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

arittr and others added 4 commits February 19, 2026 13:38
Replaces the blocking TaskOutput/wait-for-feedback.sh pattern with a
non-blocking model where the browser is an interactive display and the
terminal stays available for conversation.

Server changes:
- Write user click events to .events JSONL file (per-screen, cleared on
  new screen push) so Claude reads them on its next turn
- Replace regex-based wrapInFrame with <!-- CONTENT --> placeholder
- Add --foreground flag to start-server.sh for sandbox environments
- Harden startup with nohup/disown and liveness check

UI changes:
- Remove feedback footer (textarea + Send button)
- Add selection indicator bar ("Option X selected — return to terminal")
- Narrow click handler to [data-choice] elements only

Skill changes:
- Rewrite visual-companion.md for non-blocking loop
- Fix visual companion being skipped on Codex (no browser tools needed)
- Make visual companion offer a standalone question (one question rule)

Deletes wait-for-feedback.sh entirely.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The visual companion was a disconnected section at the bottom of SKILL.md
that agents never reached because it wasn't in the mandatory checklist.
Now step 2 evaluates whether the topic involves visual/UX decisions and
offers the companion if so. Non-visual topics (APIs, data models, etc.)
skip the step entirely.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Containers with data-multiselect allow toggling multiple selections.
Without it, behavior is unchanged (single-select). Indicator bar shows
count when multiple items are selected.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@arittr
Copy link
Collaborator Author

arittr commented Feb 19, 2026

This change is part of the following stack:

Change managed by git-spice.

@coderabbitai
Copy link

coderabbitai bot commented Feb 19, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch viz-brain-refactor

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@obra obra merged commit ce0f9a2 into dev Feb 20, 2026
1 check passed
@obra obra deleted the viz-brain-refactor branch February 20, 2026 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants