Skip to content

Comments

chore: remove unused lib/skills-core.js#525

Open
RomarQ wants to merge 1 commit intoobra:mainfrom
RomarQ:remove-dead-skills-core
Open

chore: remove unused lib/skills-core.js#525
RomarQ wants to merge 1 commit intoobra:mainfrom
RomarQ:remove-dead-skills-core

Conversation

@RomarQ
Copy link

@RomarQ RomarQ commented Feb 21, 2026

Remove lib/skills-core.js, dead code since #330.

Motivation and Context

The OpenCode plugin was the only consumer (import * as skillsCore from '../../lib/skills-core.js'). That import was removed in #330, which replaced it with an inline extractAndStripFrontmatter function. The file has had no importers since.

How Has This Been Tested?

grep -r 'skills-core'. confirms no file in the repo references it. Existing tests pass unchanged.

Breaking Changes

None. No internal or external code imports this file.

Types of changes

  • Clean-up

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

Removes a file and folder which is no-longer used anywhere in the codebase, the file exports extractFrontmatter, findSkillsInDir, checkForUpdates, resolveSkillPath, and stripFrontmatter.

@coderabbitai
Copy link

coderabbitai bot commented Feb 21, 2026

📝 Walkthrough

Walkthrough

The entire lib/skills-core.js module has been deleted, removing 208 lines of code that provided utility functions for skills management including frontmatter extraction, recursive directory discovery, skill path resolution, update checking, and YAML frontmatter stripping.

Changes

Cohort / File(s) Summary
Module Deletion
lib/skills-core.js
Complete removal of the skills-core utility module, eliminating five exported functions: extractFrontmatter, findSkillsInDir, resolveSkillPath, checkForUpdates, and stripFrontmatter. Verify no remaining code depends on these utilities.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

Poem

🐰 A module bids farewell today,
Its functions cleared and tucked away,
Five helpers once did skills pursue,
Now archived code says adieu,
The codebase hops a lighter way! 🌿

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'chore: remove unused lib/skills-core.js' directly and clearly summarizes the main change—deletion of an unused module. It is specific, concise, and accurately reflects the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description check ✅ Passed The pull request description clearly explains the rationale for removing lib/skills-core.js, referencing PR #330, the removal of the only consumer (OpenCode plugin), and verification that no files reference the module.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant