Skip to content

Conversation

@titofebus
Copy link

@titofebus titofebus commented Oct 25, 2025

Motivation and Context

How Has This Been Tested?

Breaking Changes

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

Summary by CodeRabbit

  • New Features

    • Added new refactoring skill for reducing code complexity in functions
  • Refactor

    • Rebranded project from Superpowers to Best Practice across systems
    • Updated command prefixes and configuration paths
    • Updated repository location
  • Documentation

    • Updated installation and usage instructions
    • Refreshed skill documentation for new branding
  • Chores

    • Removed license file

This commit renames all references to "superpowers" to "bestpractice" across
the entire codebase, including:

- Plugin name and repository URLs in plugin.json and marketplace.json
- Directory name: skills/using-superpowers → skills/using-bestpractice
- Skill name in frontmatter
- All documentation in README.md and RELEASE-NOTES.md
- Hooks and initialization scripts
- All skill references using superpowers: namespace → bestpractice:
- Configuration paths (~/.config/superpowers → ~/.config/bestpractice)

This is a comprehensive rename affecting documentation, configuration,
and skill cross-references to align with the new "Best Practice" naming.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
Updates:
- Added $schema field to marketplace.json for validation
- Fixed version mismatch (3.2.2 → 3.2.3) in marketplace.json
- Updated README with simple installation instructions:
  - Install from GitHub: titofebus/ccbp
  - Install from local directory
- Removed references to separate marketplace repository
- Updated repository URLs from obra/bestpractice to titofebus/ccbp
- Simplified update instructions

This makes the plugin easy to install for personal use without
needing a separate marketplace repository.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
- Deleted LICENSE file (not needed for personal use)
- Removed license field from plugin.json
- Removed License section from README

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
Changes:
1. Fixed find-polluter.sh security issues:
   - Changed shebang from #!/bin/bash to #!/usr/bin/env bash
   - Added strict error handling: set -euo pipefail
   - Fixed unsafe array iteration using mapfile
   - Properly quoted array references: "${TEST_FILES[@]}"
   - Added quotes in output examples for filenames with spaces

2. Removed lib/initialize-skills.sh:
   - Script referenced non-existent obra/bestpractice-skills repo
   - Not used anywhere (no hooks reference it)
   - Not needed for personal use installation
   - Removed empty lib/ directory

Remaining safe executable files:
- hooks/session-start.sh (already safe, properly quoted)
- skills/root-cause-tracing/find-polluter.sh (now safe)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
Add comprehensive skill for reducing cyclomatic complexity with:
- Type-safe refactoring methodology (complexity ≤ 10)
- Triple-check investigation protocol (zero tolerance for missed functions)
- Strict enforcement rules (no any, no null, no @ts-ignore)
- Testing protocol with type safety first
- Common refactoring patterns and techniques
- Integration with test-driven-development skill

Update README.md with new Refactoring skills category.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@coderabbitai
Copy link

coderabbitai bot commented Oct 25, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

This pull request rebrand the project from "Superpowers" to "Best Practice" across plugin metadata, configuration files, documentation, and skill references. Updates include marketplace identifiers, file paths (e.g., ~/.config/superpowers~/.config/bestpractice), repository URLs, and all skill interdependencies. Adds a new "reducing-complexity" skill and improves shell script robustness.

Changes

Cohort / File(s) Summary
Plugin Configuration
.claude-plugin/marketplace.json, .claude-plugin/plugin.json
Updated plugin metadata: renamed identifiers from "superpowers" to "bestpractice", bumped version to 3.2.3, added $schema field, and updated repository/homepage URLs to new GitHub namespace.
Project Documentation
README.md, RELEASE-NOTES.md, LICENSE
Rebranded README with "Best Practice" terminology and updated slash commands from /superpowers:* to /bestpractice:*. Updated RELEASE-NOTES with version history and branding updates. Removed MIT License file.
Hooks & Initialization
hooks/session-start.sh
Updated plugin context and skill paths from superpowers to bestpractice (~/.config/superpowers/skills~/.config/bestpractice/skills). Updated referenced skill file from using-superpowers to using-bestpractice. Added explicit exit 0.
Skill Initialization Removal
lib/initialize-skills.sh
Entire script removed; previously handled skills directory initialization, git repository updates, and fork prompting.
Skill Documentation—Branding Updates
skills/brainstorming/SKILL.md, skills/executing-plans/SKILL.md, skills/requesting-code-review/SKILL.md, skills/subagent-driven-development/SKILL.md, skills/systematic-debugging/SKILL.md, skills/testing-skills-with-subagents/SKILL.md, skills/using-bestpractice/SKILL.md, skills/using-git-worktrees/SKILL.md, skills/writing-plans/SKILL.md, skills/writing-skills/SKILL.md
Updated all sub-skill references and context paths to use bestpractice: prefix instead of superpowers:. Updated local skill directory paths from ~/.config/superpowers/skills to ~/.config/bestpractice/skills. Updated skill front-matter identifiers.
New Skill
skills/reducing-complexity/SKILL.md
Added new skill documentation for reducing cyclomatic complexity in functions. Includes multi-phase refactoring process, testing protocols, enforcement rules, common patterns, and reporting format.
Shell Script Improvements
skills/root-cause-tracing/find-polluter.sh
Enhanced portability and error handling: updated shebang to /usr/bin/env bash, enabled stricter shell options (set -euo pipefail), added argument validation, converted test file collection to Bash array, added pre-check logic for existing pollution, and improved quoted path handling.
Skill Documentation—Path Updates
skills/sharing-skills/SKILL.md
Updated directory references from ~/.config/superpowers/skills/ to ~/.config/bestpractice/skills/ in prerequisites and workflow steps.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~22 minutes

  • Areas requiring extra attention:
    • Removal of lib/initialize-skills.sh: Verify that no critical initialization logic is lost and that downstream hooks/processes handle skills initialization correctly in its absence.
    • New skills/reducing-complexity/SKILL.md: Review the completeness and accuracy of the multi-phase refactoring process, QA workflow, and reporting format for production use.
    • Improvements to skills/root-cause-tracing/find-polluter.sh: Validate that the stricter shell options (set -euo pipefail), array-based file iteration, and quoted path handling do not introduce regressions in edge cases (spaces in paths, empty arrays, etc.).
    • Path consistency: Confirm that all renamed paths in configuration, documentation, and code are consistent and do not leave orphaned references.

Possibly related PRs

  • Add personal superpowers overlay system #2: Touches the same hooks/session-start.sh and filesystem skill-paths; main PR's path/naming updates directly related to that PR's skill setup and path resolution logic.
  • Skills Repository Separation v2.0.0 #6: Modifies lib/initialize-skills.sh and hooks/session-start.sh with skills initialization; main PR removes the initialization script and updates related hook references.

Poem

🐰 From Powers of old to Best Practice we bound,
Renaming the paths where our skills now are found,
Bestpractice thrives with complexity tamed,
The refactoring dance, once taught, never blamed. ✨

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 19e2997 and a3cae6d.

📒 Files selected for processing (20)
  • .claude-plugin/marketplace.json (1 hunks)
  • .claude-plugin/plugin.json (1 hunks)
  • LICENSE (0 hunks)
  • README.md (6 hunks)
  • RELEASE-NOTES.md (14 hunks)
  • hooks/session-start.sh (2 hunks)
  • lib/initialize-skills.sh (0 hunks)
  • skills/brainstorming/SKILL.md (2 hunks)
  • skills/executing-plans/SKILL.md (1 hunks)
  • skills/reducing-complexity/SKILL.md (1 hunks)
  • skills/requesting-code-review/SKILL.md (3 hunks)
  • skills/root-cause-tracing/find-polluter.sh (3 hunks)
  • skills/sharing-skills/SKILL.md (3 hunks)
  • skills/subagent-driven-development/SKILL.md (2 hunks)
  • skills/systematic-debugging/SKILL.md (2 hunks)
  • skills/testing-skills-with-subagents/SKILL.md (1 hunks)
  • skills/using-bestpractice/SKILL.md (1 hunks)
  • skills/using-git-worktrees/SKILL.md (3 hunks)
  • skills/writing-plans/SKILL.md (2 hunks)
  • skills/writing-skills/SKILL.md (4 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@titofebus titofebus closed this Oct 25, 2025
@titofebus titofebus changed the title Claude/rename superpowers to bestpractice 011 cut7 qd8e rlg1i biu y ec lt Claude/rename superpowers to bestpractice Oct 25, 2025
@titofebus titofebus deleted the claude/rename-superpowers-to-bestpractice-011CUT7QD8eRLG1iBiuYEcLT branch October 25, 2025 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants