feat: add opt-in knowledge management integration (ADR + DISCOVERIES) #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Systematic approach to consolidate 5 repositories into superpowers plugin: - Sequential deep analysis (repo-by-repo, feature-by-feature) - Fill gaps, minimize bloat, eliminate ambiguity - Preserve dependencies, convert to first-class primitives - Document rejections, commit after each decision 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Detailed task breakdown for consolidating 5 repositories: - Setup phase (rejected features log, inventory script) - Sequential repository processing - Feature-by-feature evaluation with user decision gates - Completion phase (summary, dependency verification) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Research skill for understanding technical decision evolution. Updated to reference memory system instead of remembering-conversations. Source: superpowers-skills/skills/research/tracing-knowledge-lineages
Redundant with local-semantic-memory MCP server. Will be incorporated into memory server V2 as plugin.
- simplification-cascades: Collapse complexity via unifying abstractions - collision-zone-thinking: Force unrelated concepts together for innovation - meta-pattern-recognition: Spot universal patterns across 3+ domains - inversion-exercise: Flip assumptions to reveal alternatives - scale-game: Test at extremes to expose fundamental truths - when-stuck: Dispatch router to right problem-solving technique Source: superpowers-skills/skills/problem-solving/
Architecture skill for recognizing when to preserve multiple valid approaches vs forcing premature resolution. Teaches trade-off preservation patterns via configuration/parallel implementations. Source: superpowers-skills/skills/architecture/preserving-productive-tensions
Architecture mismatch with Claude Code plugin system.
Architecture mismatch - designed for single upstream tracking.
Preserve source attribution for skills derived from microsoft/amplifier: - Problem-solving skills (6 skills from insight-synthesizer agent) - Research skills (tracing-knowledge-lineages from knowledge-archaeologist) - Architecture skills (preserving-productive-tensions from ambiguity-guardian) Source: superpowers-skills/skills/*/ABOUT.md
Valuable concepts for enhancing existing planning workflow.
Continuous validation and migration tracking concepts valuable.
Automatic issue discovery and context detection concepts valuable.
Holistic documentation management across README, CHANGELOG, API docs, and guides. Four modes: overview, smart update, session documentation, context-aware updates. Includes smart CHANGELOG with version suggestions and custom content preservation. Source: CCPlugins/commands/docs.md
Test troubleshooting and auto-fix patterns valuable.
Pattern discovery and convention replication concepts valuable.
Vulnerability assessment and risk prioritization concepts valuable.
Systematic codebase discovery and pattern recognition concepts valuable.
Proactive problem identification with risk assessment framework. Analyzes likelihood, impact, timeline, and effort for future issues. Complements reactive debugging with forward-looking prevention. Source: CCPlugins/commands/predict-issues.md
GitHub-specific utility automation, not teachable technique.
Pre-commit quality gates and message generation concepts valuable.
Redundant with existing code review infrastructure.
Unified cleanup skill covering: - Code cleanup: comment assessment (WHY vs WHAT), debug statement removal - Project cleanup: artifact identification, safe deletion patterns - Safety patterns: git checkpoints, protected directories, verification Extracted concepts from remove-comments and cleanproject commands. Source: CCPlugins/commands/remove-comments.md + cleanproject.md
Replace inline documentation checklist with mandatory documentation-management skill invocation. This prevents documentation drift by eliminating judgment calls about whether changes warrant documentation updates. Changes: - Step 2 now requires invoking documentation-management skill (no exceptions) - Uses authority + social proof persuasion principles - Fast path when docs are synchronized, comprehensive when updates needed - Treats documentation verification as non-negotiable as passing tests
Moved commit guidelines from standalone skill to base.md Git Workflow section. Writing-commits was a style guide, not a workflow skill - never invoked, only referenced. Style guides belong with other coding preferences. Changes: - Add Git Workflow section to base.md with persuasion principles (authority + social proof) - Remove writing-commits skill directory - Update README.md and CHANGELOG.md to remove references - Emphasize absolute co-authorship prohibition
Merged obra/superpowers v3.3.1 improvements for better efficiency: - Prep phase: research project state before asking questions - Share synthesized understanding first, ask only for gaps - Lead with recommendations when presenting alternatives - Own prioritization when repo context is clear Preserved custom Phase 1.5 (external reference analysis) and Phase 4.5 (design challenge). Source: obra/superpowers commits c88b0d6..e3208f1
Integrated upstream proactive research improvements
Applied Strunk & White principles to custom skills:
- Use positive form ("Skip when" vs "Don't use when")
- Omit needless words ("Why" vs "Why mandatory", remove "likely")
- Replace "NEVER" with "AVOID" for consistency
- Convert negative directives to positive actions
Skills improved:
- extracting-patterns-from-projects
- enhancing-superpowers
- documentation-management
- predict-issues
Follows upstream v3.3.1 brainstorming skill clarity pattern
- Added comprehensive updates on Amplifier's design intelligence capability and new agents - Documented notable changes in both Amplifier and Claude-Settings projects - Revised recommendations and priority assessments based on new findings - Updated document version and change log for clarity
PostToolUse hook running 'prek run --all-files' caused crashes by modifying files Claude wasn't working on, creating file state mismatches. Created hook_run_prek.py that: - Runs prek only on specific file being edited/written - Reports output only when prek returns non-zero - Uses hookEventName field for proper additionalContext display - Never blocks, just informs Claude of formatting/errors Updated hooks.json to use new script and removed Task/MultiEdit from matcher since those don't have file_path in tool_input. Also fixed import order in hook_enforce_modern_tools.py (auto-formatted by prek).
The branch check is only relevant for actual git commits, not for file edits during development.
…s-from-projects skills # Conflicts: # skills/brainstorming/SKILL.md # skills/documentation-management/SKILL.md # skills/predict-issues/SKILL.md
- Create docs/decisions/ with README and ADR template - Create docs/discoveries/ with DISCOVERIES template - Document decision to adopt pattern in ADR 001 - Superpowers now dogfoods own pattern
|
Caution Review failedThe pull request is closed. WalkthroughA comprehensive plugin update introducing knowledge management infrastructure (ADRs/DISCOVERIES), reorganized skills library with new problem-solving techniques, pre-commit tooling configuration, enforcement hooks for modern tooling, and extensive documentation restructuring including README, CHANGELOG, and inline skill guides. Plugin metadata updated with new ownership. Legacy initialization script removed. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant SetupCommand as /setup-knowledge-management<br/>Command
participant Preflight as Pre-flight Checks
participant Templates as Template Generator
participant Git as Git Commit
User->>SetupCommand: Trigger setup-knowledge-management
SetupCommand->>Preflight: Verify docs/decisions & docs/discoveries exist
alt Directories Missing
Preflight-->>User: Present options (skip/create/show templates)
User->>SetupCommand: Choose action (create)
end
SetupCommand->>Templates: Generate docs/decisions/README.md
Templates-->>SetupCommand: ADR template created
SetupCommand->>Templates: Generate docs/discoveries/DISCOVERIES.md
Templates-->>SetupCommand: Discovery template created
SetupCommand->>Templates: Create example ADR (001-adopt-knowledge-management.md)
Templates-->>SetupCommand: Example ADR created
SetupCommand->>Git: Stage & commit knowledge-management structure
Git-->>User: Setup complete ✓
sequenceDiagram
participant Agent as Claude Agent
participant PreTool as PreToolUse Hook<br/>(hook_enforce_modern_tools)
participant Command as Command Execution
participant PostTool as PostToolUse Hook<br/>(hook_run_prek)
Agent->>PreTool: Attempt: grep -r "pattern" src/
PreTool->>PreTool: Check if code search detected
alt Legacy Tool Detected
PreTool-->>Agent: ❌ Denial: Use ripgrep (rg) instead<br/>Reason: Modern alternative available
Agent->>Agent: Acknowledge & reformulate
Agent->>Command: Execute: rg "pattern" src/
else Modern Tool
PreTool-->>Command: ✓ Allow command
end
Command->>PostTool: Tool modified file.ts
PostTool->>PostTool: Check .pre-commit-config.yaml exists
PostTool->>PostTool: Run: prek --skip no-commit-to-branch --files file.ts
alt Formatting Changes Applied
PostTool-->>Agent: Output: Prek formatting applied
else No Changes
PostTool-->>Agent: Formatted file ready
end
Estimated code review effort🎯 4 (Complex) | ⏱️ ~50 minutes Areas requiring extra attention:
Possibly related PRs
Poem
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (62)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Author
|
Wrong target repo - reopening against fork |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Integrates opt-in knowledge management patterns from Microsoft Amplifier project: Architecture Decision Records (ADR) and DISCOVERIES pattern for tracking non-obvious problems and solutions. These complement personal
memusage with project-level, git-tracked documentation.Changes
/setup-knowledge-managementwith embedded templates for ADR and DISCOVERIES setupsystematic-debugging- Document discoveries after finding non-obvious root causesroot-cause-tracing- Record complete trace paths and solutionswhen-stuck- Check known issues before investigatingpredict-issues- Track predictions in ADRs or DISCOVERIESdocumentation-management- Include ADRs and DISCOVERIES in documentation typeswriting-plans- Review relevant ADRs during planningbrainstorming- Check decisions during research and document architectural choicesenhancing-superpowers- Document integration decisionsextracting-patterns-from-projects- Record pattern extraction decisionsmem addwhen patterns not enabledArchitectural Approach
test -d docs/decisionsandtest -f docs/discoveries/DISCOVERIES.mdbefore usingImplementation Details
Based on comprehensive analysis of Microsoft Amplifier project patterns (see
docs/amplifier-analysis.md), extracted and adapted for superpowers philosophy. Complete implementation plan indocs/plans/2025-11-03-knowledge-management-implementation-plan.md.18 files changed, 3005 insertions(+), 18 deletions(-)
Summary by CodeRabbit
New Features
/setup-knowledge-managementslash command to initialize opt-in documentation structures.Documentation
Chores