-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AIX Support to the collector #1652
base: release/v1.60.0
Are you sure you want to change the base?
Conversation
This doesn't even create AIX packages currently, as it is not currently supported by nfpm. I have open issues to have support added. I just wanted to be ahead of it. Once/if it is supported, it would only build rpm packages anyway, just like it only builds an msi for Windows. Seems like a lot of unneeded duplication of code to me, making it harder to maintain.
That would be easy enough to do, but the changes are so simple, is it truly worth it? These scripts in general are super simple. |
Since the rpm portion doesn't currently work, I've restored the pre/post install scripts to what we had before. We can deal with that if the nfpm tooling adds AIX support. |
edd34a5
to
1891329
Compare
71930de
to
99e2834
Compare
f21cdf1
to
6e96f2a
Compare
37e0fa8
to
5dba843
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Dylan-M we should remove Corbin from this PR, if you can.
@jsirianni We aren't going to be able to vet the list of receivers any deeper than we currently have due to expanded list of customers potentially needing it. |
5bfade1
to
ab1535e
Compare
@ryancgoins @jsirianni @dpaasman00 @BinaryFissionGames Hey gents, I've just refreshed this PR this morning to bring it up to the current "default" release branch. I know the hardware isn't ready yet (yes, we have an actual Power server now that will run AIX), but I'm trying to be as prepped for that as possible ahead of time. Were there any outstanding comments that need addressed beforehand? I know we had some discussion around changing some of the scripts to where AIX has its own unique ones instead of shared. Is that still a concern? |
No high level concerns here. I'm fine with the script being shared between linux and AIX (it is called install_unix.sh after all). |
0a0d942
to
a474c49
Compare
… of install script
c49d843
to
ab2f1a6
Compare
feat(AIX):
= Enable building and deploying the collector for AIXProposed Change
Add AIX support to the collector.
Checklist