fix: install_unix.sh breaks with status code 2 in non-interactive environments #1813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dithmer
requested review from
dpaasman00,
BinaryFissionGames and
a team
as code owners
|
|
dithmer
changed the title
dithmer
changed the title
BinaryFissionGames
requested changes
Aug 26, 2024
Comment on lines
+38
to
+42
| IS_INTERACTIVE="false" | ||
| case "$-" in | ||
| *i*) IS_INTERACTIVE="true" ;; | ||
| esac | ||
|
|
There was a problem hiding this comment.
This seems to always be false in the environment I'm testing in 🤔
For reference, I'm testing in a fresh Ubuntu Server 24.04 install. The exiting with status code 2 issue is fixed, but we don't get the coloring like we should.
BinaryFissionGames
force-pushed
the
release/v1.59.0
branch
from
0a0d942
to
a474c49
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Change
The script "install_unix.sh" was not working in non-interactive shells, because there are tools used (stty and tput) for which a connected tty is mandatory. This is being fixed by a sh-compliant way of checking if the
$-contains thei-flag.Checklist