fix: Replace mutex with channel for TelemetryCounter #1981
+60
−52
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Change
Users are seeing agents stuck at restart after reconfiguring, and my working hypothesis is that the agent is having trouble with a pipeline that includes 16 count_telemetry processors, each of which uses a mutex. The obvious problem is that the agent defers unlocking the mutex until the next consumer in the ConsumeLogs chain returns, but it seemed like a good idea to rewrite the processor using channels instead of mutexes, the preferred Go synchronization method
From a mutex profile of a stuck agent:
Checklist