Skip to content

Commit

Permalink
no process.env.{HOSTNAME,PORT} (#854)
Browse files Browse the repository at this point in the history
  • Loading branch information
mbostock authored Feb 18, 2024
1 parent 3f09fab commit 6b1e943
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 5 deletions.
5 changes: 2 additions & 3 deletions bin/observable.ts
Original file line number Diff line number Diff line change
Expand Up @@ -128,11 +128,10 @@ try {
...CONFIG_OPTION,
host: {
type: "string",
default: process.env.HOSTNAME ?? "127.0.0.1"
default: "127.0.0.1"
},
port: {
type: "string",
default: process.env.PORT
type: "string"
},
open: {
type: "boolean",
Expand Down
4 changes: 2 additions & 2 deletions test/preview/preview-test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ import type {PreviewOptions, PreviewServer} from "../../src/preview.js";
import {mockJsDelivr} from "../mocks/jsdelivr.js";

const testHostRoot = "test/preview/dashboard";
const testHostName = process.env.TEST_HOSTNAME ?? "127.0.0.1";
const testPort = +(process.env.TEST_PORT ?? 8080);
const testHostName = "127.0.0.1";
const testPort = 3000;

const testServerOptions: PreviewOptions = {
config: await normalizeConfig({root: testHostRoot}),
Expand Down

0 comments on commit 6b1e943

Please sign in to comment.