Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node.querySelectorAll is not a function in 1.10.0 #1559

Closed
thewilkybarkid opened this issue Aug 8, 2024 · 3 comments
Closed

node.querySelectorAll is not a function in 1.10.0 #1559

thewilkybarkid opened this issue Aug 8, 2024 · 3 comments
Assignees
Labels
bug Something isn’t working

Comments

@thewilkybarkid
Copy link

We've just upgraded from 1.9.0 to 1.10.0, and our inputs are now broken with a node.querySelectorAll is not a function, coming from:

const expanded = node.querySelectorAll(".observablehq--expanded");

I've only quickly looked into it, but it seems to be getting all DOM nodes, not just elements.

@thewilkybarkid thewilkybarkid added the bug Something isn’t working label Aug 8, 2024
@mbostock mbostock self-assigned this Aug 8, 2024
@mbostock
Copy link
Member

mbostock commented Aug 8, 2024

Hmm. This might occur if you are displaying non-elements such as text nodes or comments. I’ll investigate.

@mbostock
Copy link
Member

mbostock commented Aug 9, 2024

Apologies for this obvious crash. I’ve pushed a fix and we’ll release 1.10.1 shortly (once #1557 lands).

@mbostock
Copy link
Member

mbostock commented Aug 9, 2024

Fixed in #1561.

@mbostock mbostock closed this as completed Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn’t working
Projects
None yet
Development

No branches or pull requests

2 participants