Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

case sensitive page URLs #1683

Closed
Fil opened this issue Sep 25, 2024 · 2 comments · Fixed by #1698
Closed

case sensitive page URLs #1683

Fil opened this issue Sep 25, 2024 · 2 comments · Fixed by #1698
Labels
bug Something isn’t working

Comments

@Fil
Copy link
Contributor

Fil commented Sep 25, 2024

Like #1367 but for pages. Suppose I have a path/to/page.md, and link to [link](/PaTh/To/PaGe). It works in preview if I'm using a case-insensitive dev machine, but will fail in prod if the server is case-sensitive. (The opposite configuration might create a bug too, but I believe it's less common.)

(Reported by mcmcclur/MarkOnFramework#5.)

Not sure how to address this one. The solution cannot be the same as #1374: the difference being that, for files, both links and paths are generated from the markdown contents (so we can spot a discrepancy if two references to the same file point to different casings that end up at the same place on disk). For pages, the paths are generated from the src folder, and the links from the markdown contents.

🤔

@Fil Fil added the bug Something isn’t working label Sep 25, 2024
@mbostock
Copy link
Member

Doesn’t this fall under broken link detection #363? If we validate links, we can do a case-sensitive check. But currently we don’t validate links to pages at all. Close this as duplicate?

@Fil
Copy link
Contributor Author

Fil commented Sep 25, 2024

duplicate

@Fil Fil closed this as not planned Won't fix, can't repro, duplicate, stale Sep 25, 2024
Fil added a commit that referenced this issue Sep 30, 2024
mbostock added a commit that referenced this issue Sep 30, 2024
* detect broken links

closes #363
closes #1683

* move links, anchors

* tidy link checking

* edits

* validateLinks

* tweak style

---------

Co-authored-by: Mike Bostock <mbostock@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn’t working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants