Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create should run yarn install automatically. #564

Closed
mythmon opened this issue Jan 19, 2024 · 1 comment
Closed

Create should run yarn install automatically. #564

mythmon opened this issue Jan 19, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@mythmon
Copy link
Member

mythmon commented Jan 19, 2024

Currently after creating a project we ask that users

  • cd into the directory
  • run yarn install
  • run yarn dev

We can't really automate the first and third, but we can automate away the second.

We should attempt to run yarn install (or npm install, as appropriate). This aligns well with other's projects create packages.

We should take care to handle errors here. If the relevant package manager can't be found on the path, or if it runs with an error, we should explain the problem to the user and ask them to run the install command themselves.

@mythmon mythmon added the enhancement New feature or request label Jan 19, 2024
@trebor trebor self-assigned this Jan 25, 2024
@mbostock
Copy link
Member

mbostock commented Feb 1, 2024

Fixed in #627.

@mbostock mbostock closed this as completed Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants