-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adopt clack #627
adopt clack #627
Conversation
@mbostock there isn't an easy fix for the unit test, i'm hunting around for an alternative, but no luck so far. i could perhaps make a moch clack or something like that. that said, i don't want to hold this show up. so not sure if i should dive deeper on the unit test or bypass it for now. |
@trebor I spent some time today trying to use Clack elsewhere. I wasn't able to find any way to mock it directly. Instead I'm using the effect pattern and isolating all the Clack call into funtions that I swap out in tests. |
(Referencing the 4 months old open PR bombshell-dev/clack#163 since it hasn't been mentioned yet from what I could tell.) |
I’m investigating testing now, and then I’ll approve (hopefully with a workaround, but we’ll see). |
btw: i ran tests with create and everything ran smooth. |
I implemented some simple mocks for clack. It should do the trick for now. |
Co-authored-by: Robert Harris <trebor@observablehq.com>
great, thank you! we ready to merge? |
I found some more bugs in path validation (like, it didn’t support creating nested folders, or handle the path being a file). I’m testing some more and will approve & merge shortly. |
woo, excited to use clack :) |
changes:
empty
templatedefault
and empty filesREADME.md