Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
just a prototype… there's still a lot to do
This works in user land, which makes it easy to hack on and also means that anyone will be able to substitute whatever we come up with with their own code.
I'm beginning to think that this (when it's ready) should be the default inspector for Arrow tables, and not only tied to the
sql
fenced code blocks. (I don't think anyone will miss the current inspector which shows aHo
object with cryptic properties—and if you need it to debug something, you can just put the Arrow table inside an Array.)I don't use DuckDB (yet) but maybe it will become necessary when we add filtering. But there will be a trade-off because setting up a DuckDB instance can only be slower than not doing it. We'll see what's easiest and fastest.
I also use Plot for faster prototyping, but the actual implementation will likely use d3. We'll need some kind of preprocessing of the channels, so we don't compute the bins twice.
The bin width is also often too small. I'm "hacking" the rects so that they are always visible, but a better implementation will be needed…(and maybe that's a flaw in the default strategy we're using in Plot to decide the number of bins).closes #23