Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

npm:react-dom #1467

Merged
merged 1 commit into from
Jun 15, 2024
Merged

npm:react-dom #1467

merged 1 commit into from
Jun 15, 2024

Conversation

mbostock
Copy link
Member

@mbostock mbostock commented Jun 15, 2024 •
edited
Loading

Tiny optimization to React: the npm:react-dom/client endpoint imports npm:react-dom, so there’s no reason to import the former. It’s slightly faster to just import npm:react-dom directly: one less dependency.

Also deletes an unlisted and now-defunct lib/react page.

@mbostock mbostock requested a review from Fil June 15, 2024 01:13
Fil
Fil approved these changes Jun 15, 2024
View reviewed changes
Copy link
Contributor

@Fil Fil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:-)

reactjs/react.dev#3896

@mbostock mbostock merged commit 6b6ae78 into main Jun 15, 2024
4 checks passed
@mbostock mbostock deleted the mbostock/react-dom branch June 15, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fil Fil Fil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mbostock @Fil