Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt system font stacks #1592

Closed
wants to merge 5 commits into from
Closed

Adopt system font stacks #1592

wants to merge 5 commits into from

Conversation

Fil
Copy link
Contributor

@Fil Fil commented Aug 21, 2024

Default to browser font stacks, and let the developer add external vendor fonts if they want, whether in style.css or in the head option —as we do in our docs— for better performance.

I think the "transitional" stack is the closest to the spirit that we had before by loading Source Serif Pro
https://github.com/system-fonts/modern-font-stacks?tab=readme-ov-file#transitional

supersedes #1589
removes one hurdle to #423


The following screenshots show what the default style looks like, in the themes, or when applied to the documentation (that is, if you remove our the custom css).

Air
Capture d’écran 2024-08-21 à 10 21 40

Near midnight
Capture d’écran 2024-08-21 à 10 21 54

Docs 1
Capture d’écran 2024-08-21 à 10 19 19

Docs 2
Capture d’écran 2024-08-21 à 10 19 28

Docs 3
Capture d’écran 2024-08-21 à 10 20 06

Copy link
Member

@mbostock mbostock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to keep Source Serif Pro as the default. It looks a lot better than the system stack, especially on non-macOS.

@Fil Fil closed this Aug 21, 2024
@Fil Fil deleted the fil/system-fonts branch August 21, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants