-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update types #1695
Update types #1695
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the test is overkill here, especially given the number of exceptions we already need to allow. How about dropping the test but keeping the rest of the changes?
Sure, it didn't feel quite right anyway. 🙂 I also updated the Node types to match the minimum engine version. |
Did this PR introduce this warning? We should fix…
|
Thanks for tracking that down @mootari! |
A typo in an outdated markdown-it type made me notice that several of our types don't match their library versions.
This PR
he
),@types/prompts
,Some notes:
this.skip()
allowed me to at least keep them in view.yarn.lock
would be the source of truth but that seems more complicated than what I'd want to deal with.