Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix links #1729

Merged
merged 3 commits into from
Oct 8, 2024
Merged

fix links #1729

merged 3 commits into from
Oct 8, 2024

Conversation

Fil
Copy link
Contributor

@Fil Fil commented Oct 8, 2024

after abef61b

@Fil Fil requested a review from mbostock October 8, 2024 12:20
@Fil Fil enabled auto-merge (squash) October 8, 2024 12:20
mbostock
mbostock reviewed Oct 8, 2024
View reviewed changes
Copy link
Member

@mbostock mbostock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a trailing slash to /inputs/ please.

Fil
Fil commented Oct 8, 2024
View reviewed changes
Copy link
Contributor Author

@Fil Fil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a trailing slash

mbostock
mbostock approved these changes Oct 8, 2024
View reviewed changes
Copy link
Member

@mbostock mbostock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should have broken links break the build now.

@Fil Fil merged commit e8e590c into main Oct 8, 2024
4 checks passed
@Fil Fil deleted the fil/fix-links branch October 8, 2024 14:14
@Fil Fil mentioned this pull request Oct 8, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbostock mbostock mbostock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Fil @mbostock