Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Les misérables (D3 page) #349

Merged
merged 3 commits into from
Dec 7, 2023
Merged

Les misérables (D3 page) #349

merged 3 commits into from
Dec 7, 2023

Conversation

Fil
Copy link
Contributor

@Fil Fil commented Dec 7, 2023

Need to find the right wording about components. We can also "hide" the component in an import.

@Fil Fil requested a review from mbostock December 7, 2023 20:24
@Fil Fil changed the title Les misérables Les misérables (D3 page) Dec 7, 2023
mbostock
mbostock approved these changes Dec 7, 2023
View reviewed changes
Copy link
Member

@mbostock mbostock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went back to the pre-component style.

@mbostock mbostock merged commit 4f3a608 into main Dec 7, 2023
1 check passed
@mbostock mbostock deleted the fil/force branch December 7, 2023 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbostock mbostock mbostock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Fil @mbostock