Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

store deploy configuration in observable.config.ts #431

Merged
merged 6 commits into from
Jan 4, 2024
Merged

store deploy configuration in observable.config.ts #431

merged 6 commits into from
Jan 4, 2024

Conversation

mythmon
Copy link
Member

@mythmon mythmon commented Jan 3, 2024

No description provided.

@mythmon mythmon closed this Jan 3, 2024
@mythmon mythmon reopened this Jan 3, 2024
mbostock
mbostock reviewed Jan 3, 2024
View reviewed changes
src/config.ts Show resolved Hide resolved
mcglincy
mcglincy reviewed Jan 3, 2024
View reviewed changes
src/deploy.ts Outdated Show resolved Hide resolved
src/error.ts Outdated Show resolved Hide resolved
mcglincy
mcglincy reviewed Jan 3, 2024
View reviewed changes
test/deploy-test.ts Outdated Show resolved Hide resolved
mcglincy
mcglincy approved these changes Jan 3, 2024
View reviewed changes
Copy link
Contributor

@mcglincy mcglincy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple nits/questions, but LGTM after resolving Mike's comments.

mbostock
mbostock reviewed Jan 4, 2024
View reviewed changes
src/config.ts Outdated Show resolved Hide resolved
mbostock
mbostock reviewed Jan 4, 2024
View reviewed changes
src/deploy.ts Outdated Show resolved Hide resolved
@mythmon @mbostock
Apply suggestions from code review
a6be287 
Co-authored-by: Mike Bostock <mbostock@gmail.com>
@mythmon
Copy link
Member Author

mythmon commented Jan 4, 2024

One open question here: Should we recommend users check in deploy.json or add it to .gitignore? I'd lean towards checking it in.

@mythmon mythmon merged commit 8ac8fda into main Jan 4, 2024
2 checks passed
@mythmon mythmon deleted the mythmon/platform-configuration branch January 4, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbostock mbostock mbostock left review comments

@mcglincy mcglincy mcglincy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mythmon @mcglincy @mbostock