Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

throw on invalid config #473

Merged
merged 1 commit into from
Jan 10, 2024
Merged

throw on invalid config #473

merged 1 commit into from
Jan 10, 2024

Conversation

mbostock
Copy link
Member

@mbostock mbostock commented Jan 9, 2024

Only ignore ERR_MODULE_NOT_FOUND, not all errors. Fixes #470.

@mbostock mbostock requested a review from mcglincy January 9, 2024 23:44
mcglincy
mcglincy approved these changes Jan 10, 2024
View reviewed changes
Copy link
Contributor

@mcglincy mcglincy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

thanks!

@mbostock mbostock merged commit 2d4b736 into main Jan 10, 2024
2 checks passed
@mbostock mbostock deleted the mbostock/invalid-config-error branch January 10, 2024 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcglincy mcglincy mcglincy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Misformatted observablehq.config.ts should cause an obvious error
2 participants
@mbostock @mcglincy