Automatic cloud deploy #562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mythmon
commented
Jan 18, 2024
docs/.observablehq/deploy.json
Outdated
There was a problem hiding this comment.
This is checked in so that CI and other developers knows they are deploying to the correct project and not overwriting a surprise project.
mythmon
commented
Jan 18, 2024
| {name: "Mutables", path: "/javascript/mutables"}, | ||
| {name: "Mutables", path: "/javascript/mutables"} |
There was a problem hiding this comment.
Prettier did this. I can revert it if you want, but I'm inclined to keep it formatted.
|
Also, if this goes wrong, we can only tell on main. How do you feel about me just pushing new commits to main until it works, and getting them reviewed after the fact? |
mbostock
approved these changes
Jan 19, 2024
Co-authored-by: Mike Bostock <mbostock@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This won't include the examples in the deploy. The Cloudflare deployed version manually manipulates the dist directory after running build, but we don't have any mechanism to do that in the
observable deploycommand. I'm not sure how we should fix that. I also don't especially want to do it in this PR, since the primary goal for this PR is to get automatic deploys working.