-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
save search query, and restore on cmd-K #897
base: main
Are you sure you want to change the base?
Conversation
735af8d
to
51e8f36
Compare
It can be live-tested on the "pangea" project. |
What if…
I think it’s a good idea to have a way to restore previous queries. I just want it to be accessible through clicking rather than only Command-K, and I want it to be a bit more of a deliberate action than changing the normal behavior. |
The current PR is not just restoring the previous query (only one in this PR), it's also positioning the cursor to the current page (if it's one of the search results), so you can iterate through the list with one arrowDown. I'm not sure if what you suggest would be as convenient for this use case, but the only way to know is to try. (And I'm not sure if this use case is that important… it's just what I've been optimizing for as I was working on porting dozens of notebooks.) In any case I fully agree that it should work on focus, rather than only on cmd-K. (DONE) |
38e58bd
to
03adb16
Compare
This PR works as before, but on focus; it only remembers/restores the previous query, but requires a small number of actions from the user. I'm exploring the alternative UI in #1044. |
4331649
to
d4de0d1
Compare
rebased |
1acff79
to
29af671
Compare
fbf2e2b
to
9280b35
Compare
9280b35
to
dab8db7
Compare
dab8db7
to
9b0179e
Compare
as I'm working on a project with ~300 pages, I find that not having this feature is very annoying, since when I'm working on "calendar" (say…), I have to re-type the same search query again and again (I'll test a bit with the feature on, I hope that it's not annoying in a different way :-) )
/maplibre-gl#12/47.27574/11.39085/0/52
matches/maplibre-gl
closes #889
store-search-query.mp4