-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
windows support #944
windows support #944
Conversation
Co-authored-by: Mike Bostock <mike@ocks.org>
I'm enabling auto merge on this; but it won't merge until our CI configuration change to look for the newly added CI jobs instead of the old one. |
@@ -11,7 +11,9 @@ jobs: | |||
strategy: | |||
matrix: | |||
version: [20, 21] | |||
runs-on: ubuntu-latest | |||
os: [ubuntu-latest, windows-latest] | |||
fail-fast: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this do?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fail-fast: true
(the default) means that if any CI job fails, the rest are immediately cancelled. fail-fast: false
lets them all run to completion. true
saves on CI time, false
leads to easier debugging.
We need to add rimraf to the template package.json's |
Fixes #90.