Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The reverse option crashes explicit axis #1655

Closed
Fil opened this issue May 30, 2023 · 1 comment · Fixed by #1665
Closed

The reverse option crashes explicit axis #1655

Fil opened this issue May 30, 2023 · 1 comment · Fixed by #1665
Labels
question Further information is needed

Comments

@Fil
Copy link
Contributor

Fil commented May 30, 2023

Just saw that as I was making a facet axis explicit; of course I should have left the reverse option in the fy specification, but copied it over and got a TypeError: Cannot read properties of undefined (reading 'map').

minimal repro:

Plot.axisX({ reverse: true }).plot()
@Fil Fil changed the title reverse crashes explicit axis The reverse option crashes explicit axis May 30, 2023
@mbostock mbostock added the question Further information is needed label May 30, 2023
@mbostock
Copy link
Member

Same as #1457, I think.

Fil added a commit that referenced this issue Jun 1, 2023
@Fil
Axes and grids now support the filter option
5e27ff6 
Add an explicit error message if using the sort and reverse option

closes #1457
closes #1655
@Fil Fil mentioned this issue Jun 1, 2023
Merged
Fil added a commit that referenced this issue Jun 27, 2023
@Fil
Axes and grids now support the filter option
bb8acbf 
Add an explicit error message if using the sort and reverse option

closes #1457
closes #1655
@Fil Fil closed this as completed in #1665 Jun 28, 2023
Fil added a commit that referenced this issue Jun 28, 2023
@Fil
Axes and grids now support the filter option (#1665)
eb4b7c4 
* Axes and grids now support {filter, sort, reverse}

closes #1457
closes #1655
Fil added a commit that referenced this issue Aug 21, 2023
@Fil
Axes and grids now support the filter option (#1665)
52f1c98 
* Axes and grids now support {filter, sort, reverse}

closes #1457
closes #1655
chaichontat pushed a commit to chaichontat/plot that referenced this issue Jan 14, 2024
@Fil @chaichontat
Axes and grids now support the filter option (observablehq#1665)
16cc0cd 
* Axes and grids now support {filter, sort, reverse}

closes observablehq#1457
closes observablehq#1655
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question Further information is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Axes and grids now support the filter option observablehq/plot
2 participants
@Fil @mbostock