axis marks’ ariaLabel option #2162
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the ariaLabel option on the axis mark.
Including a realistic use case where we don't want the aria-label of the custom mark to be "axis-x", otherwise Plot skips the implicit axis.
Enregistrement.de.l.ecran.2024-09-05.a.13.29.59.mov
The test chart — a continuous “crosshair-x” — is not necessarily what I would recommend to use (maybe I'd anchor the new mark at the top, or I would fade out the axis mark when hovering…), but it's a nice way to see how things overlap—and consistent with what the crosshair mark does.
[Note that this is not enough to solve the continuous crosshair issue (#1629); visually OK if you add these two marks in x and y, but the Plot's value on the dispatched input event is either x or y — what we want is (x, y).]